Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1847233002: cmake move libyuv_unittest target into the if(TEST) condition (Closed)

Created:
4 years, 8 months ago by fbarchard1
Modified:
4 years, 8 months ago
CC:
diederickh_gmail.com
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

cmake move libyuv_unittest target into the if(TEST) condition BUG=libyuv:579 TESTED=mkdir build && cd build && cmake .. && cmake --build . --config Release R=kjellander@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/ef79a9938b638564bad9fb4aab6c1df26fd5f0b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M CMakeLists.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
fbarchard1
4 years, 8 months ago (2016-03-31 22:28:38 UTC) #1
fbarchard1
$ mkdir cbuild && cd cbuild && cmake .. && cmake --build . --config Release ...
4 years, 8 months ago (2016-03-31 22:31:36 UTC) #2
fbarchard1
lint and try run, but not really applicable here.
4 years, 8 months ago (2016-04-01 00:40:22 UTC) #3
kjellander_chromium
lgtm
4 years, 8 months ago (2016-04-01 07:15:32 UTC) #4
fbarchard1
4 years, 8 months ago (2016-04-01 23:15:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ef79a9938b638564bad9fb4aab6c1df26fd5f0b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698