Beef up unit test for CFX_ByteString and CFX_WideString.

Beef up unit test for CFX_ByteString and CFX_WideString.

Needed to validate refactoring which was reverted.

Committed: https://pdfium.googlesource.com/pdfium/+/de0d852ed91973deda41f949e132b12a2efff1ef

[Tom Sepez, 2016-03-31 20:54:25]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-03-31 20:54:26]

Dan, tests only. Thanks.

[Tom Sepez, 2016-03-31 20:55:03]

where tests only means tests only plus bugfixes, I guess.  PTAL at the whole
thing.

[dsinclair, 2016-03-31 21:03:56]

lgtm w/ nits. (Similar tests for the W variants if you add them)

https://codereview.chromium.org/1847193002/diff/1/core/fxcrt/fx_basic_bstring...
File core/fxcrt/fx_basic_bstring_unittest.cpp (right):

https://codereview.chromium.org/1847193002/diff/1/core/fxcrt/fx_basic_bstring...
core/fxcrt/fx_basic_bstring_unittest.cpp:331: 
freed.Remove('R');
EXPECT_EQ("", freed) ?

https://codereview.chromium.org/1847193002/diff/1/core/fxcrt/fx_basic_bstring...
core/fxcrt/fx_basic_bstring_unittest.cpp:353: }
fred.Replace("BY", "HI");
EXPECT_EQ("HI", fred);

fred.Replace("HI", "");
EXPECT_EQ("", fred)

https://codereview.chromium.org/1847193002/diff/1/core/fxcrt/fx_basic_bstring...
core/fxcrt/fx_basic_bstring_unittest.cpp:425: EXPECT_EQ("FRED", fred.Mid(0, 4));
Mid(0, 10)

[Tom Sepez, 2016-03-31 21:28:56]

Applied to WideStr as well.

https://codereview.chromium.org/1847193002/diff/1/core/fxcrt/fx_basic_bstring...
File core/fxcrt/fx_basic_bstring_unittest.cpp (right):

https://codereview.chromium.org/1847193002/diff/1/core/fxcrt/fx_basic_bstring...
core/fxcrt/fx_basic_bstring_unittest.cpp:331: 
On 2016/03/31 21:03:56, dsinclair wrote:
> freed.Remove('R');
> EXPECT_EQ("", freed) ?

Done.

https://codereview.chromium.org/1847193002/diff/1/core/fxcrt/fx_basic_bstring...
core/fxcrt/fx_basic_bstring_unittest.cpp:353: }
On 2016/03/31 21:03:56, dsinclair wrote:
> fred.Replace("BY", "HI");
> EXPECT_EQ("HI", fred);
> 
> fred.Replace("HI", "");
> EXPECT_EQ("", fred)

Done.

https://codereview.chromium.org/1847193002/diff/1/core/fxcrt/fx_basic_bstring...
core/fxcrt/fx_basic_bstring_unittest.cpp:425: EXPECT_EQ("FRED", fred.Mid(0, 4));
On 2016/03/31 21:03:56, dsinclair wrote:
> Mid(0, 10)

Done.

[Tom Sepez, 2016-03-31 21:29:15]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-03-31 21:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/1847193002/#ps20001
(title: "Few more cases.")

[commit-bot: I haz the power, 2016-03-31 21:29:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847193002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847193002/20001

[commit-bot: I haz the power, 2016-03-31 21:40:32]

Description was changed from

==========
Beef up unit test for CFX_ByteString and CFX_WideString.

Needed to validate refactoring which was reverted.
==========

to

==========
Beef up unit test for CFX_ByteString and CFX_WideString.

Needed to validate refactoring which was reverted.

Committed:
https://pdfium.googlesource.com/pdfium/+/de0d852ed91973deda41f949e132b12a2eff...
==========

[commit-bot: I haz the power, 2016-03-31 21:40:33]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/de0d852ed91973deda41f949e132b12a2eff...