[elements] Avoid using IsKey in loops

[elements] Avoid using IsKey in loops

IsKey is much slower compare to direct comparisons with undefined_value
and the_hole_value.

BUG=

Committed: https://crrev.com/ba5a61962fa428e838db0bb25e096d73b4c127de
Cr-Commit-Position: refs/heads/master@{#35209}

[Camillo Bruni, 2016-04-01 13:23:26]

cbruni@chromium.org changed reviewers:
+ yangguo@chromium.org

[Camillo Bruni, 2016-04-01 13:23:26]

PTAL

[Yang, 2016-04-01 13:29:53]

https://codereview.chromium.org/1847183004/diff/20001/src/builtins.cc
File src/builtins.cc (right):

https://codereview.chromium.org/1847183004/diff/20001/src/builtins.cc#newcode...
src/builtins.cc:1073: Handle<Object> undefined =
isolate->factory()->undefined_value();
Can we disallow allocation here and just use raw values?

https://codereview.chromium.org/1847183004/diff/20001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1847183004/diff/20001/src/elements.cc#newcode...
src/elements.cc:1198: Heap* heap = holder->GetHeap();
Can we have a disallow allocation scope here?

https://codereview.chromium.org/1847183004/diff/20001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1847183004/diff/20001/src/objects-inl.h#newco...
src/objects-inl.h:3005: bool HashTableBase::IsKey(Object* k) {
do we still need this one?

[Yang, 2016-04-01 13:30:03]

On 2016/04/01 13:29:53, Yang wrote:
> https://codereview.chromium.org/1847183004/diff/20001/src/builtins.cc
> File src/builtins.cc (right):
> 
>
https://codereview.chromium.org/1847183004/diff/20001/src/builtins.cc#newcode...
> src/builtins.cc:1073: Handle<Object> undefined =
> isolate->factory()->undefined_value();
> Can we disallow allocation here and just use raw values?
> 
> https://codereview.chromium.org/1847183004/diff/20001/src/elements.cc
> File src/elements.cc (right):
> 
>
https://codereview.chromium.org/1847183004/diff/20001/src/elements.cc#newcode...
> src/elements.cc:1198: Heap* heap = holder->GetHeap();
> Can we have a disallow allocation scope here?
> 
> https://codereview.chromium.org/1847183004/diff/20001/src/objects-inl.h
> File src/objects-inl.h (right):
> 
>
https://codereview.chromium.org/1847183004/diff/20001/src/objects-inl.h#newco...
> src/objects-inl.h:3005: bool HashTableBase::IsKey(Object* k) {
> do we still need this one?

lgtm aside from these comments.

[Camillo Bruni, 2016-04-01 13:51:10]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2016-04-01 13:51:11]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1847183004/#ps40001
(title: "addressing comments")

[commit-bot: I haz the power, 2016-04-01 13:51:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847183004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847183004/40001

[commit-bot: I haz the power, 2016-04-01 14:39:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-01 14:40:20]

Description was changed from

==========
[elements] Avoid using IsKey in loops

IsKey is much slower compare to direct comparisons with undefined_value
and the_hole_value.

BUG=
==========

to

==========
[elements] Avoid using IsKey in loops

IsKey is much slower compare to direct comparisons with undefined_value
and the_hole_value.

BUG=

Committed: https://crrev.com/ba5a61962fa428e838db0bb25e096d73b4c127de
Cr-Commit-Position: refs/heads/master@{#35209}
==========

[commit-bot: I haz the power, 2016-04-01 14:40:21]

Patchset 3 (id:??) landed as
https://crrev.com/ba5a61962fa428e838db0bb25e096d73b4c127de
Cr-Commit-Position: refs/heads/master@{#35209}