device/usb/mojo/permission_provider.h - Issue 1847183002: Use interface associations to check function permissions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/mojo/permission_provider.h

Issue 1847183002: Use interface associations to check function permissions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed browser_test build and addressed juncai@'s comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/mojo/permission_provider.h

diff --git a/device/usb/mojo/permission_provider.h b/device/usb/mojo/permission_provider.h

index 8366047cb74626546eb7dee493c7d9d89cded539..a58984ce6f469e7bdf5c442753e6c014bd3f58ec 100644

--- a/device/usb/mojo/permission_provider.h

+++ b/device/usb/mojo/permission_provider.h

@@ -23,9 +23,9 @@ class PermissionProvider {

virtual bool HasConfigurationPermission(

uint8_t requested_configuration,

const DeviceInfo& device_info) const = 0;

- virtual bool HasInterfacePermission(uint8_t requested_interface,

- uint8_t configuration_value,

- const DeviceInfo& device_info) const = 0;

+ virtual bool HasFunctionPermission(uint8_t requested_function,

+ uint8_t configuration_value,

+ const DeviceInfo& device_info) const = 0;

};

} // namespace usb

« device/usb/mojo/mock_permission_provider.h ('K') | « device/usb/mojo/mock_permission_provider.cc ('k') | device/usb/mojo/type_converters.cc » ('j') | no next file with comments »