Revert "Revert of Remove font cache code (patchset #3 id:40001 of https://codereview.chromium.org/1…

Revert "Revert of Remove font cache code (patchset #3 id:40001 of https://codereview.chromium.org/1834763003/ )"

This reverts commit a9d0fa26f4f6223b55b4817d06584346c25c6aa8.

Conflicts:
	content/ppapi_plugin/ppapi_plugin_main.cc
	content/renderer/renderer_main_platform_delegate_win.cc

BUG=525142
Committed: https://crrev.com/e9b78323dfe6e90fdf0ae8f0bb07b56f2910d0db
Cr-Commit-Position: refs/heads/master@{#384771}

[Ilya Kulshin, 2016-03-31 22:04:00]

The CQ bit was checked by kulshin@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:04:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847173002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847173002/1

[commit-bot: I haz the power, 2016-03-31 22:04:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:04:40]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Ilya Kulshin, 2016-03-31 22:04:49]

Description was changed from

==========
Revert "Revert of Remove font cache code (patchset #3 id:40001 of
https://codereview.chromium.org/1834763003/ )"

This reverts commit a9d0fa26f4f6223b55b4817d06584346c25c6aa8.

Conflicts:
	content/ppapi_plugin/ppapi_plugin_main.cc
	content/renderer/renderer_main_platform_delegate_win.cc

BUG=
==========

to

==========
Revert "Revert of Remove font cache code (patchset #3 id:40001 of
https://codereview.chromium.org/1834763003/ )"

This reverts commit a9d0fa26f4f6223b55b4817d06584346c25c6aa8.

Conflicts:
	content/ppapi_plugin/ppapi_plugin_main.cc
	content/renderer/renderer_main_platform_delegate_win.cc

BUG=525142
==========

[Ilya Kulshin, 2016-03-31 22:04:49]

kulshin@chromium.org changed reviewers:
+ jochen@chromium.org, jschuh@chromium.org

[Ilya Kulshin, 2016-03-31 22:08:24]

ptal.

This is the same code (mod merge conflicts) as was landed
in issue https://codereview.chromium.org/1834763003/.
The original change was reverted due to failing webkit
layout tests. I've been unable to get definitive results
locally, but the webkit_tests bot shows the tests are now
passing. I've verified the same tests are being run, so I
want to see if there is still an actual problem, now that
the original failing bot is green.

[jochen (gone - plz use gerrit), 2016-04-01 08:42:35]

lgtm

[jschuh, 2016-04-01 13:57:00]

lgtm

[Ilya Kulshin, 2016-04-01 21:49:08]

ptal.

I was eventually able to repro the failures locally, and confirmed that
I think the behavior is still correct, so I'm rebaselining the failing
tests.
I examined the results of the failing tests. Most failures are due to minor
spacing issues. One failure is due to rendering characters which
previously could not be rendered. Some failures are due to using a
different font variant (not sure why it's picking a different variant).
Some failures are due to using a different font (I believe the new code
is more correct in these cases - perhaps it was previously failing to
load these fonts?).

I think I have all the approvals needed, but I'd still like someone to
look over the change and lgtm it again before I land it.

[jschuh, 2016-04-01 22:00:54]

lgtm

[Ilya Kulshin, 2016-04-01 22:03:40]

The CQ bit was checked by kulshin@chromium.org

[Ilya Kulshin, 2016-04-01 22:03:41]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1847173002/#ps20001
(title: "Add test expectations to rebaseline tests on Win10")

[commit-bot: I haz the power, 2016-04-01 22:04:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1847173002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1847173002/20001

[commit-bot: I haz the power, 2016-04-02 01:27:45]

Description was changed from

==========
Revert "Revert of Remove font cache code (patchset #3 id:40001 of
https://codereview.chromium.org/1834763003/ )"

This reverts commit a9d0fa26f4f6223b55b4817d06584346c25c6aa8.

Conflicts:
	content/ppapi_plugin/ppapi_plugin_main.cc
	content/renderer/renderer_main_platform_delegate_win.cc

BUG=525142
==========

to

==========
Revert "Revert of Remove font cache code (patchset #3 id:40001 of
https://codereview.chromium.org/1834763003/ )"

This reverts commit a9d0fa26f4f6223b55b4817d06584346c25c6aa8.

Conflicts:
	content/ppapi_plugin/ppapi_plugin_main.cc
	content/renderer/renderer_main_platform_delegate_win.cc

BUG=525142
==========

[commit-bot: I haz the power, 2016-04-02 01:27:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-02 01:28:41]

Description was changed from

==========
Revert "Revert of Remove font cache code (patchset #3 id:40001 of
https://codereview.chromium.org/1834763003/ )"

This reverts commit a9d0fa26f4f6223b55b4817d06584346c25c6aa8.

Conflicts:
	content/ppapi_plugin/ppapi_plugin_main.cc
	content/renderer/renderer_main_platform_delegate_win.cc

BUG=525142
==========

to

==========
Revert "Revert of Remove font cache code (patchset #3 id:40001 of
https://codereview.chromium.org/1834763003/ )"

This reverts commit a9d0fa26f4f6223b55b4817d06584346c25c6aa8.

Conflicts:
	content/ppapi_plugin/ppapi_plugin_main.cc
	content/renderer/renderer_main_platform_delegate_win.cc

BUG=525142

Committed: https://crrev.com/e9b78323dfe6e90fdf0ae8f0bb07b56f2910d0db
Cr-Commit-Position: refs/heads/master@{#384771}
==========

[commit-bot: I haz the power, 2016-04-02 01:28:42]

Patchset 2 (id:??) landed as
https://crrev.com/e9b78323dfe6e90fdf0ae8f0bb07b56f2910d0db
Cr-Commit-Position: refs/heads/master@{#384771}