Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1847163002: Regen against latest analyzer (Closed)

Created:
4 years, 8 months ago by vsm
Modified:
4 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Regen against latest analyzer A couple notes: - regress_18535_test started failing at runtime. It's using unimplemented mirrors code, so perhaps a static failure before. - typed_data_sublist_type_dart started failing at runtime. It was inferring Is<EfficientLength> with the type omitted. :-( - my local chrome is newer than the one on travis failing on generators. not seeing that error. TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/b7d043967909be6f2dc57acb30e2b42441699a40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -181 lines) Patch
M lib/runtime/dart/convert.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/js.js View 1 chunk +1 line, -1 line 0 comments Download
M test/browser/language_tests.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/collection/src/algorithms.js View 10 chunks +31 lines, -65 lines 0 comments Download
M test/codegen/expect/collection/src/algorithms.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/canonicalized_map.js View 6 chunks +12 lines, -6 lines 0 comments Download
M test/codegen/expect/collection/src/canonicalized_map.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/equality.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M test/codegen/expect/collection/src/iterable_zip.js View 1 chunk +47 lines, -35 lines 0 comments Download
M test/codegen/expect/collection/src/iterable_zip.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/collection/src/priority_queue.js View 9 chunks +14 lines, -10 lines 0 comments Download
M test/codegen/expect/collection/src/priority_queue.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/queue_list.js View 2 chunks +7 lines, -7 lines 0 comments Download
M test/codegen/expect/collection/src/queue_list.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M test/codegen/expect/collection/src/utils.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/codegen/expect/collection/src/wrappers.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M test/codegen/expect/language-all.js View Binary file 0 comments Download
M test/codegen/expect/lib-typed_data-all.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/codegen/lib/typed_data/typed_data_sublist_type_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
vsm
Committed patchset #1 (id:1) manually as b7d043967909be6f2dc57acb30e2b42441699a40 (presubmit successful).
4 years, 8 months ago (2016-03-31 20:19:05 UTC) #2
Jennifer Messerly
4 years, 8 months ago (2016-04-04 16:30:46 UTC) #3
Message was sent while issue was closed. 
lgtm!

Powered by Google App Engine
This is Rietveld 408576698