Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: test/mjsunit/es6/regexp-flags.js

Issue 1847103002: Ship --harmony-regexp-exec (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Just fix the test instead Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Flags: --harmony-unicode-regexps 5 // Flags: --harmony-unicode-regexps
6 6
7 var r1 = /abc/gi; 7 var r1 = /abc/gi;
8 assertEquals("abc", r1.source); 8 assertEquals("abc", r1.source);
9 assertTrue(r1.global); 9 assertTrue(r1.global);
10 assertTrue(r1.ignoreCase); 10 assertTrue(r1.ignoreCase);
(...skipping 26 matching lines...) Expand all
37 get: function() { get_count++; return true; } 37 get: function() { get_count++; return true; }
38 }); 38 });
39 39
40 assertTrue(r3.global); 40 assertTrue(r3.global);
41 assertEquals(1, get_count); 41 assertEquals(1, get_count);
42 assertTrue(r3.ignoreCase); 42 assertTrue(r3.ignoreCase);
43 assertEquals(2, get_count); 43 assertEquals(2, get_count);
44 // Overridden flag getters affects the flags getter. 44 // Overridden flag getters affects the flags getter.
45 assertEquals("gi", r3.flags); 45 assertEquals("gi", r3.flags);
46 assertEquals(4, get_count); 46 assertEquals(4, get_count);
47 // Overridden flag getters do not affect the internal flags. 47 // Overridden flag getters affect string.replace
48 // TODO(adamk): Add more tests here once we've switched
49 // to use [[OriginalFlags]] in more cases.
48 assertEquals(expected, string.replace(r3, "X")); 50 assertEquals(expected, string.replace(r3, "X"));
49 assertEquals(4, get_count); 51 assertEquals(5, get_count);
50 52
51 53
52 function testName(name) { 54 function testName(name) {
53 // TODO(littledan): For web compatibility, we don't throw an exception, 55 // TODO(littledan): For web compatibility, we don't throw an exception,
54 // but ES2015 expects an exception to be thrown from this getter. 56 // but ES2015 expects an exception to be thrown from this getter.
55 if (name === "source") { 57 if (name === "source") {
56 assertThrows(() => RegExp.prototype[name], TypeError); 58 assertThrows(() => RegExp.prototype[name], TypeError);
57 } else { 59 } else {
58 assertEquals(undefined, RegExp.prototype[name]); 60 assertEquals(undefined, RegExp.prototype[name]);
59 } 61 }
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 }, 115 },
114 get unicode() { 116 get unicode() {
115 map.u = counter++; 117 map.u = counter++;
116 }, 118 },
117 get sticky() { 119 get sticky() {
118 map.y = counter++; 120 map.y = counter++;
119 } 121 }
120 }; 122 };
121 testGenericFlags(object); 123 testGenericFlags(object);
122 assertEquals({ g: 0, i: 1, m: 2, u: 3, y: 4 }, map); 124 assertEquals({ g: 0, i: 1, m: 2, u: 3, y: 4 }, map);
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698