Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1847103002: Ship --harmony-regexp-exec (Closed)

Created:
4 years, 8 months ago by adamk
Modified:
4 years, 8 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship --harmony-regexp-exec There are still spec compliance fixes to be made, but this patch turns the flag to shipping to make sure we get more canary coverage and performance data from the bots. BUG=v8:4602 LOG=y Committed: https://crrev.com/84492bb66b340f4e0df36758e98fddbb10b5d1dc Cr-Commit-Position: refs/heads/master@{#35181}

Patch Set 1 #

Patch Set 2 : Mark test as failing in ignition #

Patch Set 3 : Just fix the test instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download
M test/mjsunit/es6/regexp-flags.js View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
adamk
4 years, 8 months ago (2016-03-31 17:21:59 UTC) #2
Dan Ehrenberg
lgtm Good to go in now, but we need to make sure to put in ...
4 years, 8 months ago (2016-03-31 17:26:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847103002/1
4 years, 8 months ago (2016-03-31 17:29:23 UTC) #5
adamk
On 2016/03/31 17:26:30, Dan Ehrenberg wrote: > lgtm > > Good to go in now, ...
4 years, 8 months ago (2016-03-31 17:29:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15984)
4 years, 8 months ago (2016-03-31 17:40:21 UTC) #8
adamk
+rmcilroy FYI, this fails one test under --ignition
4 years, 8 months ago (2016-03-31 17:47:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847103002/20001
4 years, 8 months ago (2016-03-31 17:47:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15989)
4 years, 8 months ago (2016-03-31 18:06:25 UTC) #14
adamk
Hmm, okay, something definitely wrong demonstrated by that regexp-flags test, will have to look into ...
4 years, 8 months ago (2016-03-31 18:11:27 UTC) #15
adamk
On 2016/03/31 18:11:27, adamk wrote: > Hmm, okay, something definitely wrong demonstrated by that regexp-flags ...
4 years, 8 months ago (2016-03-31 23:31:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847103002/40001
4 years, 8 months ago (2016-03-31 23:31:45 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-01 00:38:12 UTC) #20
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/84492bb66b340f4e0df36758e98fddbb10b5d1dc Cr-Commit-Position: refs/heads/master@{#35181}
4 years, 8 months ago (2016-04-01 00:39:35 UTC) #22
Michael Hablich
4 years, 8 months ago (2016-04-01 10:47:05 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1852673003/ by hablich@chromium.org.

The reason for reverting is: breaks some chromium browser_tests:
https://codereview.chromium.org/1848233002/.

Powered by Google App Engine
This is Rietveld 408576698