|
|
DescriptionShip --harmony-regexp-exec
There are still spec compliance fixes to be made, but this patch
turns the flag to shipping to make sure we get more canary coverage
and performance data from the bots.
BUG=v8:4602
LOG=y
Committed: https://crrev.com/84492bb66b340f4e0df36758e98fddbb10b5d1dc
Cr-Commit-Position: refs/heads/master@{#35181}
Patch Set 1 #Patch Set 2 : Mark test as failing in ignition #Patch Set 3 : Just fix the test instead #
Messages
Total messages: 23 (9 generated)
adamk@chromium.org changed reviewers: + hablich@chromium.org, littledan@chromium.org
lgtm Good to go in now, but we need to make sure to put in the last bits of TC39's spec changes before the branch.
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847103002/1
On 2016/03/31 17:26:30, Dan Ehrenberg wrote: > lgtm > > Good to go in now, but we need to make sure to put in the last bits of TC39's > spec changes before the branch. Agreed that we have fixes to make, ideally before the branch (I think that ought to be no problem).
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
+rmcilroy FYI, this fails one test under --ignition
The CQ bit was checked by adamk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/1847103002/#ps20001 (title: "Mark test as failing in ignition")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847103002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847103002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
Hmm, okay, something definitely wrong demonstrated by that regexp-flags test, will have to look into this in more detail.
On 2016/03/31 18:11:27, adamk wrote: > Hmm, okay, something definitely wrong demonstrated by that regexp-flags test, > will have to look into this in more detail. Test just needed an update due to the fact that this flag is shipping. Fixed it, and removed the fail expectation. Ross, ignore the noise :)
The CQ bit was checked by adamk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from littledan@chromium.org Link to the patchset: https://codereview.chromium.org/1847103002/#ps40001 (title: "Just fix the test instead")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847103002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847103002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Ship --harmony-regexp-exec There are still spec compliance fixes to be made, but this patch turns the flag to shipping to make sure we get more canary coverage and performance data from the bots. BUG=v8:4602 LOG=y ========== to ========== Ship --harmony-regexp-exec There are still spec compliance fixes to be made, but this patch turns the flag to shipping to make sure we get more canary coverage and performance data from the bots. BUG=v8:4602 LOG=y Committed: https://crrev.com/84492bb66b340f4e0df36758e98fddbb10b5d1dc Cr-Commit-Position: refs/heads/master@{#35181} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/84492bb66b340f4e0df36758e98fddbb10b5d1dc Cr-Commit-Position: refs/heads/master@{#35181}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1852673003/ by hablich@chromium.org. The reason for reverting is: breaks some chromium browser_tests: https://codereview.chromium.org/1848233002/. |