Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1847073002: Undoing unintended change to code-stub-assembler (Closed)

Created:
4 years, 8 months ago by Mircea Trofin
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Undoing unintended change to code-stub-assembler introduced by 53d51c52f3754fe0e7decacba4277e58cf9fb5a4 (frame elision). Turns out it was the cause of the regression in the referenced bug. BUG=599421 LOG=N Committed: https://crrev.com/223001850421e2af3006631cf79d526cfcb408dc Cr-Commit-Position: refs/heads/master@{#35175}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/code-stub-assembler.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Mircea Trofin
4 years, 8 months ago (2016-03-31 17:05:41 UTC) #4
bradnelson
lgtm
4 years, 8 months ago (2016-03-31 17:17:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847073002/1
4 years, 8 months ago (2016-03-31 17:17:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 17:23:15 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 17:24:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/223001850421e2af3006631cf79d526cfcb408dc
Cr-Commit-Position: refs/heads/master@{#35175}

Powered by Google App Engine
This is Rietveld 408576698