chrome/app/generated_resources.grd - Issue 1847063005: [Media, UI] Change MediaNotification style to MediaStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 1847063005: [Media, UI] Change MediaNotification style to MediaStyle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests and rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/NotificationTitleUpdatedTest.java ('k') | chrome/browser/about_flags.cc » ('j') | chrome/browser/about_flags.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index ab15b94411111c945724bf1b82a3fe18a12988a3..1d96ee361017d698ee5faae0eae55380dedcef89 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -5602,6 +5602,12 @@ Keep your key file in a safe place. You will need it to create new versions of y

User gesture requirement for playing media elements. Disabling this will allow autoplay to work.

</message>

+ <message name="IDS_FLAGS_USE_NEW_MEDIA_NOTIFICATION_NAME" desc="Title for the flag for using new media style notification">

+ New media notification style

mlamouri (slow - plz ping) 2016/04/07 19:47:34 Media Style Notifications

Zhiqiang Zhang (Slow) 2016/04/11 09:26:28 Done.

+ </message>

+ <message name="IDS_FLAGS_USE_NEW_MEDIA_NOTIFICATION_DESCRIPTION" desc="Description for the flag for using new media style notification">

+ Better looking notification when Chrome plays media.

mlamouri (slow - plz ping) 2016/04/07 19:47:34 Use Android MediaStyle notifications for Chrome me

Zhiqiang Zhang (Slow) 2016/04/11 09:26:28 Done.

+ </message>

Window backdrops in TouchView