chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java - Issue 1847063005: [Media, UI] Change MediaNotification style to MediaStyle

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java

Issue 1847063005: [Media, UI] Change MediaNotification style to MediaStyle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests and rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.chrome.browser;	5 package org.chromium.chrome.browser;

6	6

7 import org.chromium.base.annotations.JNINamespace;	7 import org.chromium.base.annotations.JNINamespace;

8 import org.chromium.base.annotations.MainDex;	8 import org.chromium.base.annotations.MainDex;

9	9

10 /**	10 /**

(...skipping 14 matching lines...) Expand all Loading...
25 * @param featureName The name of the feature to query.	25 * @param featureName The name of the feature to query.

26 * @return Whether the feature is enabled or not.	26 * @return Whether the feature is enabled or not.

27 */	27 */

28 public static boolean isEnabled(String featureName) {	28 public static boolean isEnabled(String featureName) {

29 return nativeIsEnabled(featureName);	29 return nativeIsEnabled(featureName);

30 }	30 }

31	31

32 public static final String NTP_SNIPPETS = "NTPSnippets";	32 public static final String NTP_SNIPPETS = "NTPSnippets";

33 public static final String NTP_TOOLBAR = "NTPToolbar";	33 public static final String NTP_TOOLBAR = "NTPToolbar";

34 public static final String NTP_FAKE_OMNIBOX_TEXT = "NTPFakeOmniboxText";	34 public static final String NTP_FAKE_OMNIBOX_TEXT = "NTPFakeOmniboxText";

	35 public static final String USE_NEW_MEDIA_NOTIFICATION = "UseNewMediaNotifica tion";
	mlamouri (slow - plz ping) 2016/04/07 19:47:34 "MediaStyleNotifications" might be a better name b "MediaStyleNotifications" might be a better name because self explanatory. (applies here and below) Zhiqiang Zhang (Slow) 2016/04/11 09:26:28 Done. Show quoted text On 2016/04/07 19:47:34, Mounir Lamouri wrote: > "MediaStyleNotifications" might be a better name because self explanatory. > > (applies here and below) Done.
35	36

36 private static native boolean nativeIsEnabled(String featureName);	37 private static native boolean nativeIsEnabled(String featureName);

37 }	38 }

OLD	NEW