Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1847053004: Update SkAlphaThresholdFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : Fixed sample app #

Patch Set 4 : Fix sample app #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M gm/imagealphathreshold.cpp View 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkAlphaThresholdFilter.h View 1 2 chunks +11 lines, -2 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 4 chunks +11 lines, -9 lines 0 comments Download
M tests/FlattenableFactoryToName.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
robertphillips
4 years, 8 months ago (2016-03-31 20:01:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847053004/20001
4 years, 8 months ago (2016-04-01 11:41:38 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/5824)
4 years, 8 months ago (2016-04-01 11:43:29 UTC) #8
f(malita)
LGTM % SampleFilterFuzz build fix.
4 years, 8 months ago (2016-04-01 13:34:51 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847053004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847053004/60001
4 years, 8 months ago (2016-04-01 16:36:22 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 16:46:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1847053004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1847053004/60001
4 years, 8 months ago (2016-04-01 17:33:50 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 17:34:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/f624204300d8cd3b2cdb933b144980ff56852d42

Powered by Google App Engine
This is Rietveld 408576698