Remove IXFA_* interfaces.

Remove IXFA_* interfaces.

This CL removes the IXFA_* interfaces which are:
 - Implemented once.
 - Not implemented by an fpdfsdk class.

This requires making a few classes visible to fpdfsdk so we can have the
correct instances available instead of the IXFA types.

Committed: https://pdfium.googlesource.com/pdfium/+/df4bc596c64fb848647c670be66a29ea0861b4f4

[dsinclair, 2016-03-31 15:16:42]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-03-31 15:16:43]

PTAL.

I wanted to remove these before doing the xfa/include move as it removes a bunch
of interface classes.

https://codereview.chromium.org/1846993002/diff/1/xfa/fxfa/app/xfa_ffdocview.cpp
File xfa/fxfa/app/xfa_ffdocview.cpp (left):

https://codereview.chromium.org/1846993002/diff/1/xfa/fxfa/app/xfa_ffdocview....
xfa/fxfa/app/xfa_ffdocview.cpp:887: IXFA_WidgetAccIterator*
XFA_WidgetAccIterator_Create(
Never called.

[Tom Sepez, 2016-03-31 17:01:58]

Ok, please also double-check that we don't have any xfa/ files including
fpdfsdk/ files as a result of removing any of these APIs.  (I think that its OK
though, but check).

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoc.cpp
File xfa/fxfa/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoc....
xfa/fxfa/app/xfa_ffdoc.cpp:23: #include
"xfa/fxfa/parser/xfa_document_serialize.h"
nit: alphabetize

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoc....
xfa/fxfa/app/xfa_ffdoc.cpp:427: CXFA_DataImporter* pImport = new
CXFA_DataImporter(m_pDocument);
nit: if this were std::unique_ptr<..., ReleaseDeleter<CFXA_DataImporter>

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoc....
xfa/fxfa/app/xfa_ffdoc.cpp:428: bRet = pImport->ImportData(pStream);
... then we could lose the bret local and just return here.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
File xfa/fxfa/app/xfa_ffdochandler.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
xfa/fxfa/app/xfa_ffdochandler.cpp:68: void
CXFA_FFDocHandler::SetJSERuntime(CXFA_FFDoc* hDoc,
nit: funny, this used to fin in 80 cols.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdocv...
File xfa/fxfa/app/xfa_ffdocview.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdocv...
xfa/fxfa/app/xfa_ffdocview.cpp:20: #include "xfa/include/fxfa/xfa_ffpageview.h"
alphabetize.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffexcl...
File xfa/fxfa/app/xfa_ffexclgroup.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffexcl...
xfa/fxfa/app/xfa_ffexclgroup.cpp:11: #include "xfa/include/fxfa/xfa_ffdoc.h"
nit: alphabetize

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fffiel...
File xfa/fxfa/app/xfa_fffield.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fffiel...
xfa/fxfa/app/xfa_fffield.cpp:14: #include "xfa/include/fxfa/xfa_ffapp.h"
nit: alphabetize

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fffield.h
File xfa/fxfa/app/xfa_fffield.h (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fffiel...
xfa/fxfa/app/xfa_fffield.h:14: #include "xfa/fxfa/app/xfa_ffwidget.h"
nit: alphabetize

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffimag...
File xfa/fxfa/app/xfa_ffimage.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffimag...
xfa/fxfa/app/xfa_ffimage.cpp:9: #include "xfa/include/fxfa/xfa_ffapp.h"
Check the rest of these for alphabetization, thanks.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffwidg...
File xfa/fxfa/app/xfa_ffwidgethandler.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidgethandler.cpp:574: FX_BOOL
CXFA_FFMenuHandler::CanCopy(CXFA_FFWidget* hWidget) {
These are all kinda pointless now, at a minimum, we can lose the casts.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fontmg...
File xfa/fxfa/app/xfa_fontmgr.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fontmg...
xfa/fxfa/app/xfa_fontmgr.cpp:1766:
static_cast<CXFA_FFDoc*>(hDoc)->GetApp()->GetFDEFontMgr();
cast not needed.  You might want to take another pass to see if there are others
as I'm not sure that I caught all of these in my review.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fontmg...
xfa/fxfa/app/xfa_fontmgr.cpp:2061: m_PDFFontMgrArray.SetAt(hDoc, new
CXFA_PDFFontMgr((CXFA_FFDoc*)hDoc));
like here.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fwlthe...
File xfa/fxfa/app/xfa_fwltheme.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fwlthe...
xfa/fxfa/app/xfa_fwltheme.cpp:24: #include "xfa/include/fxfa/xfa_ffapp.h"
alphabetize

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_textla...
File xfa/fxfa/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_textla...
xfa/fxfa/app/xfa_textlayout.cpp:19: #include "xfa/fxfa/app/xfa_ffwidgetacc.h"
alpha

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:20: #include "xfa/fxfa/app/xfa_ffnotify.h"
alpha

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_lay...
File xfa/fxfa/parser/xfa_layout_itemlayout.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_lay...
xfa/fxfa/parser/xfa_layout_itemlayout.cpp:26: #include
"xfa/fxfa/app/xfa_ffnotify.h"
alpha

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_lay...
File xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_lay...
xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp:613: return
m_PageArray.Find(static_cast<CXFA_ContainerLayoutItem*>(
one of these casts can go.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_loc...
File xfa/fxfa/parser/xfa_locale.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_loc...
xfa/fxfa/parser/xfa_locale.cpp:110: CXFA_TimeZoneProvider* pProvider =
CXFA_TimeZoneProvider::Get();
nit: local not needed.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_loc...
xfa/fxfa/parser/xfa_locale.cpp:280: void
CXFA_NodeLocale::GetTimeZone(FX_TIMEZONE& tz) const {
nit: local not needed.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_obj...
File xfa/fxfa/parser/xfa_object_imp.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_obj...
xfa/fxfa/parser/xfa_object_imp.cpp:24: #include
"xfa/fxfa/parser/xfa_parser_imp.h"
alpha

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_obj...
File xfa/fxfa/parser/xfa_objectacc_imp.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_obj...
xfa/fxfa/parser/xfa_objectacc_imp.cpp:19: #include "xfa/fxfa/app/xfa_ffnotify.h"
alpha

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:21: #include
"xfa/include/fxfa/xfa_checksum.h"
alf

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.h (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.h:29: CXFA_Document* GetFactory() const override
{ return m_pFactory; }
nit: virtual methods implemented in .h -- move to .cpp in a subsequent cl.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
File xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp:23: #include
"xfa/fxfa/app/xfa_ffnotify.h"
alf

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
File xfa/fxfa/parser/xfa_script_resolveprocessor.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
xfa/fxfa/parser/xfa_script_resolveprocessor.cpp:697: CXFA_ScriptContext*
pContext = NULL;
nit: move to line 708

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
File xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp:21: #include
"xfa/fxfa/app/xfa_ffnotify.h"
al

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/fxfa.h
File xfa/include/fxfa/fxfa.h (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/fxfa.h...
xfa/include/fxfa/fxfa.h:16: class CXFA_FFPageView;
alphabetize

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
File xfa/include/fxfa/xfa_ffpageview.h (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
xfa/include/fxfa/xfa_ffpageview.h:50: virtual CXFA_FFWidget* MoveToFirst();
override

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
xfa/include/fxfa/xfa_ffpageview.h:59: CXFA_FFPageView* m_pPageView;
nit: blank line here.

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
xfa/include/fxfa/xfa_ffpageview.h:82: virtual void Reset();
overrides

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
xfa/include/fxfa/xfa_ffpageview.h:96: CXFA_FFWidget*
GetTraverseWidget(CXFA_FFWidget* pWidget);
nit: methods first, blank line, then members.

[dsinclair, 2016-03-31 17:06:51]

All of the removed IXFA types were from xfa/ so I added xfa includes to fpdfsdk,
but not the other way around.

pdfium/pdfium/xfa % git grep fpdfsdk
fxjse/DEPS:  '+fpdfsdk/include/jsapi',
fxjse/runtime.cpp:#include "fpdfsdk/include/jsapi/fxjs_v8.h"
fxjse/runtime.cpp:// Duplicates fpdfsdk's JS_Runtime.h, but keeps XFA from
depending on it.

So, just the existing one.

[dsinclair, 2016-03-31 19:52:28]

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoc.cpp
File xfa/fxfa/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoc....
xfa/fxfa/app/xfa_ffdoc.cpp:23: #include
"xfa/fxfa/parser/xfa_document_serialize.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> nit: alphabetize

Doh, forgot to run sort-headers.py

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoc....
xfa/fxfa/app/xfa_ffdoc.cpp:427: CXFA_DataImporter* pImport = new
CXFA_DataImporter(m_pDocument);
On 2016/03/31 17:01:57, Tom Sepez wrote:
> nit: if this were std::unique_ptr<..., ReleaseDeleter<CFXA_DataImporter>

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoc....
xfa/fxfa/app/xfa_ffdoc.cpp:428: bRet = pImport->ImportData(pStream);
On 2016/03/31 17:01:57, Tom Sepez wrote:
> ... then we could lose the bret local and just return here.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
File xfa/fxfa/app/xfa_ffdochandler.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
xfa/fxfa/app/xfa_ffdochandler.cpp:68: void
CXFA_FFDocHandler::SetJSERuntime(CXFA_FFDoc* hDoc,
On 2016/03/31 17:01:57, Tom Sepez wrote:
> nit: funny, this used to fin in 80 cols.

CXFA_FFDoc is longer then IXFA_Doc. At some point I'll probably kill the FF's in
the name as I have no idea what they mean.....

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdocv...
File xfa/fxfa/app/xfa_ffdocview.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdocv...
xfa/fxfa/app/xfa_ffdocview.cpp:20: #include "xfa/include/fxfa/xfa_ffpageview.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> alphabetize.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffexcl...
File xfa/fxfa/app/xfa_ffexclgroup.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffexcl...
xfa/fxfa/app/xfa_ffexclgroup.cpp:11: #include "xfa/include/fxfa/xfa_ffdoc.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fffiel...
File xfa/fxfa/app/xfa_fffield.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fffiel...
xfa/fxfa/app/xfa_fffield.cpp:14: #include "xfa/include/fxfa/xfa_ffapp.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fffield.h
File xfa/fxfa/app/xfa_fffield.h (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fffiel...
xfa/fxfa/app/xfa_fffield.h:14: #include "xfa/fxfa/app/xfa_ffwidget.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> nit: alphabetize

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffimag...
File xfa/fxfa/app/xfa_ffimage.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffimag...
xfa/fxfa/app/xfa_ffimage.cpp:9: #include "xfa/include/fxfa/xfa_ffapp.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> Check the rest of these for alphabetization, thanks.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffwidg...
File xfa/fxfa/app/xfa_ffwidgethandler.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffwidg...
xfa/fxfa/app/xfa_ffwidgethandler.cpp:574: FX_BOOL
CXFA_FFMenuHandler::CanCopy(CXFA_FFWidget* hWidget) {
On 2016/03/31 17:01:57, Tom Sepez wrote:
> These are all kinda pointless now, at a minimum, we can lose the casts.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fontmg...
File xfa/fxfa/app/xfa_fontmgr.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fontmg...
xfa/fxfa/app/xfa_fontmgr.cpp:1766:
static_cast<CXFA_FFDoc*>(hDoc)->GetApp()->GetFDEFontMgr();
On 2016/03/31 17:01:57, Tom Sepez wrote:
> cast not needed.  You might want to take another pass to see if there are
others
> as I'm not sure that I caught all of these in my review.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fontmg...
xfa/fxfa/app/xfa_fontmgr.cpp:2061: m_PDFFontMgrArray.SetAt(hDoc, new
CXFA_PDFFontMgr((CXFA_FFDoc*)hDoc));
On 2016/03/31 17:01:57, Tom Sepez wrote:
> like here.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fwlthe...
File xfa/fxfa/app/xfa_fwltheme.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_fwlthe...
xfa/fxfa/app/xfa_fwltheme.cpp:24: #include "xfa/include/fxfa/xfa_ffapp.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> alphabetize

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_textla...
File xfa/fxfa/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_textla...
xfa/fxfa/app/xfa_textlayout.cpp:19: #include "xfa/fxfa/app/xfa_ffwidgetacc.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> alpha

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
File xfa/fxfa/fm2js/xfa_fm2jscontext.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/fm2js/xfa_fm2j...
xfa/fxfa/fm2js/xfa_fm2jscontext.cpp:20: #include "xfa/fxfa/app/xfa_ffnotify.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> alpha

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_lay...
File xfa/fxfa/parser/xfa_layout_itemlayout.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_lay...
xfa/fxfa/parser/xfa_layout_itemlayout.cpp:26: #include
"xfa/fxfa/app/xfa_ffnotify.h"
On 2016/03/31 17:01:57, Tom Sepez wrote:
> alpha

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_lay...
File xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_lay...
xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp:613: return
m_PageArray.Find(static_cast<CXFA_ContainerLayoutItem*>(
On 2016/03/31 17:01:57, Tom Sepez wrote:
> one of these casts can go.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_loc...
File xfa/fxfa/parser/xfa_locale.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_loc...
xfa/fxfa/parser/xfa_locale.cpp:110: CXFA_TimeZoneProvider* pProvider =
CXFA_TimeZoneProvider::Get();
On 2016/03/31 17:01:57, Tom Sepez wrote:
> nit: local not needed.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_loc...
xfa/fxfa/parser/xfa_locale.cpp:280: void
CXFA_NodeLocale::GetTimeZone(FX_TIMEZONE& tz) const {
On 2016/03/31 17:01:57, Tom Sepez wrote:
> nit: local not needed.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_obj...
File xfa/fxfa/parser/xfa_object_imp.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_obj...
xfa/fxfa/parser/xfa_object_imp.cpp:24: #include
"xfa/fxfa/parser/xfa_parser_imp.h"
On 2016/03/31 17:01:58, Tom Sepez wrote:
> alpha

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_obj...
File xfa/fxfa/parser/xfa_objectacc_imp.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_obj...
xfa/fxfa/parser/xfa_objectacc_imp.cpp:19: #include "xfa/fxfa/app/xfa_ffnotify.h"
On 2016/03/31 17:01:58, Tom Sepez wrote:
> alpha

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.cpp:21: #include
"xfa/include/fxfa/xfa_checksum.h"
On 2016/03/31 17:01:58, Tom Sepez wrote:
> alf

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_par...
File xfa/fxfa/parser/xfa_parser_imp.h (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_par...
xfa/fxfa/parser/xfa_parser_imp.h:29: CXFA_Document* GetFactory() const override
{ return m_pFactory; }
On 2016/03/31 17:01:58, Tom Sepez wrote:
> nit: virtual methods implemented in .h -- move to .cpp in a subsequent cl.

Acknowledged.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
File xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp:23: #include
"xfa/fxfa/app/xfa_ffnotify.h"
On 2016/03/31 17:01:58, Tom Sepez wrote:
> alf

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
File xfa/fxfa/parser/xfa_script_resolveprocessor.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
xfa/fxfa/parser/xfa_script_resolveprocessor.cpp:697: CXFA_ScriptContext*
pContext = NULL;
On 2016/03/31 17:01:58, Tom Sepez wrote:
> nit: move to line 708

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
File xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/parser/xfa_scr...
xfa/fxfa/parser/xfa_script_signaturepseudomodel.cpp:21: #include
"xfa/fxfa/app/xfa_ffnotify.h"
On 2016/03/31 17:01:58, Tom Sepez wrote:
> al

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/fxfa.h
File xfa/include/fxfa/fxfa.h (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/fxfa.h...
xfa/include/fxfa/fxfa.h:16: class CXFA_FFPageView;
On 2016/03/31 17:01:58, Tom Sepez wrote:
> alphabetize

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
File xfa/include/fxfa/xfa_ffpageview.h (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
xfa/include/fxfa/xfa_ffpageview.h:50: virtual CXFA_FFWidget* MoveToFirst();
On 2016/03/31 17:01:58, Tom Sepez wrote:
> override

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
xfa/include/fxfa/xfa_ffpageview.h:59: CXFA_FFPageView* m_pPageView;
On 2016/03/31 17:01:58, Tom Sepez wrote:
> nit: blank line here.

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
xfa/include/fxfa/xfa_ffpageview.h:82: virtual void Reset();
On 2016/03/31 17:01:58, Tom Sepez wrote:
> overrides

Done.

https://codereview.chromium.org/1846993002/diff/20001/xfa/include/fxfa/xfa_ff...
xfa/include/fxfa/xfa_ffpageview.h:96: CXFA_FFWidget*
GetTraverseWidget(CXFA_FFWidget* pWidget);
On 2016/03/31 17:01:58, Tom Sepez wrote:
> nit: methods first, blank line, then members.

Done.

[Tom Sepez, 2016-03-31 21:49:28]

lgtm

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
File xfa/fxfa/app/xfa_ffdochandler.cpp (right):

https://codereview.chromium.org/1846993002/diff/20001/xfa/fxfa/app/xfa_ffdoch...
xfa/fxfa/app/xfa_ffdochandler.cpp:68: void
CXFA_FFDocHandler::SetJSERuntime(CXFA_FFDoc* hDoc,
On 2016/03/31 19:52:26, dsinclair wrote:
> On 2016/03/31 17:01:57, Tom Sepez wrote:
> > nit: funny, this used to fin in 80 cols.
> 
> CXFA_FFDoc is longer then IXFA_Doc. At some point I'll probably kill the FF's
in
> the name as I have no idea what they mean.....

I didn't notice the FF.  FF probably mean form fill

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/app/xfa_ffdoc.cpp
File xfa/fxfa/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/app/xfa_ffdoc....
xfa/fxfa/app/xfa_ffdoc.cpp:427: return std::unique_ptr<CXFA_DataImporter,
ReleaseDeleter<CXFA_DataImporter>>(
nit: here's one place where I would continue to use the local to emphasize that
there's a cleanup at the end, not sure why I like that better ...

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/parser/xfa_doc...
File xfa/fxfa/parser/xfa_document_serialize.h (right):

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_serialize.h:20: CXFA_Document* m_pDocument;
can this be CFXA_Document* const m_pDocument?

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_serialize.h:39: CXFA_Document* m_pDocument;
can this be CFXA_Document* const m_pDocument, too?

[dsinclair, 2016-04-01 03:19:17]

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/app/xfa_ffdoc.cpp
File xfa/fxfa/app/xfa_ffdoc.cpp (right):

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/app/xfa_ffdoc....
xfa/fxfa/app/xfa_ffdoc.cpp:427: return std::unique_ptr<CXFA_DataImporter,
ReleaseDeleter<CXFA_DataImporter>>(
On 2016/03/31 21:49:27, Tom Sepez wrote:
> nit: here's one place where I would continue to use the local to emphasize
that
> there's a cleanup at the end, not sure why I like that better ...

Done.

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/parser/xfa_doc...
File xfa/fxfa/parser/xfa_document_serialize.h (right):

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_serialize.h:20: CXFA_Document* m_pDocument;
On 2016/03/31 21:49:28, Tom Sepez wrote:
> can this be CFXA_Document* const m_pDocument?

Done.

https://codereview.chromium.org/1846993002/diff/40001/xfa/fxfa/parser/xfa_doc...
xfa/fxfa/parser/xfa_document_serialize.h:39: CXFA_Document* m_pDocument;
On 2016/03/31 21:49:28, Tom Sepez wrote:
> can this be CFXA_Document* const m_pDocument, too?

Done.

[dsinclair, 2016-04-01 03:25:32]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-01 03:25:33]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1846993002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-01 03:25:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846993002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846993002/60001

[commit-bot: I haz the power, 2016-04-01 03:34:46]

Description was changed from

==========
Remove IXFA_* interfaces.

This CL removes the IXFA_* interfaces which are:
 - Implemented once.
 - Not implemented by an fpdfsdk class.

This requires making a few classes visible to fpdfsdk so we can have the
correct instances available instead of the IXFA types.
==========

to

==========
Remove IXFA_* interfaces.

This CL removes the IXFA_* interfaces which are:
 - Implemented once.
 - Not implemented by an fpdfsdk class.

This requires making a few classes visible to fpdfsdk so we can have the
correct instances available instead of the IXFA types.

Committed:
https://pdfium.googlesource.com/pdfium/+/df4bc596c64fb848647c670be66a29ea0861...
==========

[commit-bot: I haz the power, 2016-04-01 03:34:47]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/df4bc596c64fb848647c670be66a29ea0861...