Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 1846983002: [tools] Beef up GC eval scripts (Closed)

Created:
4 years, 8 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Beef up GC eval scripts * Add csv output mode for spreadsheet pasting * Add option to leave out top-level categories * Deal with unknown categories R=hpayer@chromium.org LOG=N BUG= NOTRY=true Committed: https://crrev.com/c80f2bf80ca892fbf45e374a2137316000a24660 Cr-Commit-Position: refs/heads/master@{#35168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -51 lines) Patch
M tools/eval_gc_nvp.py View 4 chunks +25 lines, -11 lines 0 comments Download
M tools/eval_gc_time.sh View 7 chunks +76 lines, -40 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Michael Lippautz
e.g. cat out-reference-2.log |grep "gc=ms" | grep "reduce_memory=0" | ~/ssd/v8/v8/tools/eval_gc_time.sh --sort avg --csv | less
4 years, 8 months ago (2016-03-31 14:58:09 UTC) #1
Hannes Payer (out of office)
lgtm
4 years, 8 months ago (2016-03-31 15:02:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846983002/1
4 years, 8 months ago (2016-03-31 15:02:28 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-31 15:04:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846983002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846983002/1
4 years, 8 months ago (2016-03-31 15:06:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 15:07:59 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 15:09:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c80f2bf80ca892fbf45e374a2137316000a24660
Cr-Commit-Position: refs/heads/master@{#35168}

Powered by Google App Engine
This is Rietveld 408576698