src/x87/code-stubs-x87.cc - Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x87/code-stubs-x87.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x87/code-stubs-x87.cc

diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc

index c9878a6f56319fedda828f37e973ca5e5c1e5900..fa7945afffa508c9384c7d40a7dc867a615c5385 100644

--- a/src/x87/code-stubs-x87.cc

+++ b/src/x87/code-stubs-x87.cc

@@ -3549,8 +3549,8 @@ void LoadICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {

__ j(not_equal, &miss);

__ push(slot);

__ push(vector);

- Code::Flags code_flags = Code::RemoveTypeAndHolderFromFlags(

- Code::ComputeHandlerFlags(Code::LOAD_IC));

+ Code::Flags code_flags =

+ Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC));

masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, code_flags,

receiver, name, vector, scratch);

__ pop(vector);

@@ -3810,8 +3810,8 @@ void VectorStoreICStub::GenerateImpl(MacroAssembler* masm, bool in_frame) {

__ pop(value);

__ push(slot);

__ push(vector);

- Code::Flags code_flags = Code::RemoveTypeAndHolderFromFlags(

- Code::ComputeHandlerFlags(Code::STORE_IC));

+ Code::Flags code_flags =

+ Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC));

masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, code_flags,

receiver, key, slot, no_reg);

__ pop(vector);

« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »