src/profiler/heap-snapshot-generator.h - Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/heap-snapshot-generator.h

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/profiler/heap-snapshot-generator.h

diff --git a/src/profiler/heap-snapshot-generator.h b/src/profiler/heap-snapshot-generator.h

index 857f2401bf08cc5cccf6fd40bc3e8daadcd138c1..255f61da6c654afa199a29fea6ca94c231188341 100644

--- a/src/profiler/heap-snapshot-generator.h

+++ b/src/profiler/heap-snapshot-generator.h

@@ -382,7 +382,6 @@ class V8HeapExplorer : public HeapEntriesAllocator {

void ExtractScriptReferences(int entry, Script* script);

void ExtractAccessorInfoReferences(int entry, AccessorInfo* accessor_info);

void ExtractAccessorPairReferences(int entry, AccessorPair* accessors);

- void ExtractCodeCacheReferences(int entry, CodeCache* code_cache);

void ExtractCodeReferences(int entry, Code* code);

void ExtractBoxReferences(int entry, Box* box);

void ExtractCellReferences(int entry, Cell* cell);

« no previous file with comments | « src/ppc/code-stubs-ppc.cc ('k') | src/profiler/heap-snapshot-generator.cc » ('j') | no next file with comments »