src/ic/x64/ic-x64.cc - Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/x64/ic-x64.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/x64/ic-x64.cc

diff --git a/src/ic/x64/ic-x64.cc b/src/ic/x64/ic-x64.cc

index 247116d7fea28614d8229a7cbbbd7c6446b8848e..05b9264a7080de463b6424a67333cd48b5e2d133 100644

--- a/src/ic/x64/ic-x64.cc

+++ b/src/ic/x64/ic-x64.cc

@@ -340,8 +340,8 @@ void KeyedLoadIC::GenerateMegamorphic(MacroAssembler* masm) {

__ Move(vector, dummy_vector);

__ Move(slot, Smi::FromInt(slot_index));

- Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(

- Code::ComputeHandlerFlags(Code::LOAD_IC));

+ Code::Flags flags =

+ Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC));

masm->isolate()->stub_cache()->GenerateProbe(masm, Code::KEYED_LOAD_IC, flags,

receiver, key,

megamorphic_scratch, no_reg);

@@ -567,8 +567,8 @@ void KeyedStoreIC::GenerateMegamorphic(MacroAssembler* masm,

__ Move(vector, dummy_vector);

__ Move(slot, Smi::FromInt(slot_index));

- Code::Flags flags = Code::RemoveTypeAndHolderFromFlags(

- Code::ComputeHandlerFlags(Code::STORE_IC));

+ Code::Flags flags =

+ Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC));

masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, flags,

receiver, key, r9, no_reg);

// Cache miss.

« no previous file with comments | « src/ic/x64/handler-compiler-x64.cc ('k') | src/ic/x64/stub-cache-x64.cc » ('j') | no next file with comments »