src/ic/ia32/stub-cache-ia32.cc - Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ia32/stub-cache-ia32.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/ia32/stub-cache-ia32.cc

diff --git a/src/ic/ia32/stub-cache-ia32.cc b/src/ic/ia32/stub-cache-ia32.cc

index fcfae4bc0ce9246f572957d17a2f8848f091ac8d..5a32858596b73b4794d3a19931f1979e4a2eafe6 100644

--- a/src/ic/ia32/stub-cache-ia32.cc

+++ b/src/ic/ia32/stub-cache-ia32.cc

@@ -153,9 +153,6 @@ void StubCache::GenerateProbe(MacroAssembler* masm, Code::Kind ic_kind,

// being 12.

DCHECK(sizeof(Entry) == 12);

- // Assert the flags do not name a specific type.

- DCHECK(Code::ExtractTypeFromFlags(flags) == 0);

// Assert that there are no register conflicts.

DCHECK(!scratch.is(receiver));

DCHECK(!scratch.is(name));

« no previous file with comments | « src/ic/ia32/ic-ia32.cc ('k') | src/ic/ic.h » ('j') | no next file with comments »