Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Side by Side Diff: src/ia32/code-stubs-ia32.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/api-arguments.h" 8 #include "src/api-arguments.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 3839 matching lines...) Expand 10 before | Expand all | Expand 10 after
3850 __ bind(&try_array); 3850 __ bind(&try_array);
3851 __ CompareRoot(FieldOperand(scratch, 0), Heap::kFixedArrayMapRootIndex); 3851 __ CompareRoot(FieldOperand(scratch, 0), Heap::kFixedArrayMapRootIndex);
3852 __ j(not_equal, &not_array); 3852 __ j(not_equal, &not_array);
3853 HandleArrayCases(masm, receiver, name, vector, slot, scratch, true, &miss); 3853 HandleArrayCases(masm, receiver, name, vector, slot, scratch, true, &miss);
3854 3854
3855 __ bind(&not_array); 3855 __ bind(&not_array);
3856 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex); 3856 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex);
3857 __ j(not_equal, &miss); 3857 __ j(not_equal, &miss);
3858 __ push(slot); 3858 __ push(slot);
3859 __ push(vector); 3859 __ push(vector);
3860 Code::Flags code_flags = Code::RemoveTypeAndHolderFromFlags( 3860 Code::Flags code_flags =
3861 Code::ComputeHandlerFlags(Code::LOAD_IC)); 3861 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::LOAD_IC));
3862 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, code_flags, 3862 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::LOAD_IC, code_flags,
3863 receiver, name, vector, scratch); 3863 receiver, name, vector, scratch);
3864 __ pop(vector); 3864 __ pop(vector);
3865 __ pop(slot); 3865 __ pop(slot);
3866 3866
3867 __ bind(&miss); 3867 __ bind(&miss);
3868 LoadIC::GenerateMiss(masm); 3868 LoadIC::GenerateMiss(masm);
3869 } 3869 }
3870 3870
3871 3871
(...skipping 239 matching lines...) Expand 10 before | Expand all | Expand 10 after
4111 HandlePolymorphicStoreCase(masm, receiver, key, vector, slot, scratch, true, 4111 HandlePolymorphicStoreCase(masm, receiver, key, vector, slot, scratch, true,
4112 &miss); 4112 &miss);
4113 4113
4114 __ bind(&not_array); 4114 __ bind(&not_array);
4115 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex); 4115 __ CompareRoot(scratch, Heap::kmegamorphic_symbolRootIndex);
4116 __ j(not_equal, &miss); 4116 __ j(not_equal, &miss);
4117 4117
4118 __ pop(value); 4118 __ pop(value);
4119 __ push(slot); 4119 __ push(slot);
4120 __ push(vector); 4120 __ push(vector);
4121 Code::Flags code_flags = Code::RemoveTypeAndHolderFromFlags( 4121 Code::Flags code_flags =
4122 Code::ComputeHandlerFlags(Code::STORE_IC)); 4122 Code::RemoveHolderFromFlags(Code::ComputeHandlerFlags(Code::STORE_IC));
4123 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, code_flags, 4123 masm->isolate()->stub_cache()->GenerateProbe(masm, Code::STORE_IC, code_flags,
4124 receiver, key, slot, no_reg); 4124 receiver, key, slot, no_reg);
4125 __ pop(vector); 4125 __ pop(vector);
4126 __ pop(slot); 4126 __ pop(slot);
4127 Label no_pop_miss; 4127 Label no_pop_miss;
4128 __ jmp(&no_pop_miss); 4128 __ jmp(&no_pop_miss);
4129 4129
4130 __ bind(&miss); 4130 __ bind(&miss);
4131 __ pop(value); 4131 __ pop(value);
4132 __ bind(&no_pop_miss); 4132 __ bind(&no_pop_miss);
(...skipping 1706 matching lines...) Expand 10 before | Expand all | Expand 10 after
5839 return_value_operand, NULL); 5839 return_value_operand, NULL);
5840 } 5840 }
5841 5841
5842 5842
5843 #undef __ 5843 #undef __
5844 5844
5845 } // namespace internal 5845 } // namespace internal
5846 } // namespace v8 5846 } // namespace v8
5847 5847
5848 #endif // V8_TARGET_ARCH_IA32 5848 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698