Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/objects-debug.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/objects.h" 5 #include "src/objects.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/disasm.h" 8 #include "src/disasm.h"
9 #include "src/disassembler.h" 9 #include "src/disassembler.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 void Map::VerifyOmittedMapChecks() { 362 void Map::VerifyOmittedMapChecks() {
363 if (!FLAG_omit_map_checks_for_leaf_maps) return; 363 if (!FLAG_omit_map_checks_for_leaf_maps) return;
364 if (!is_stable() || 364 if (!is_stable() ||
365 is_deprecated() || 365 is_deprecated() ||
366 is_dictionary_map()) { 366 is_dictionary_map()) {
367 CHECK(dependent_code()->IsEmpty(DependentCode::kPrototypeCheckGroup)); 367 CHECK(dependent_code()->IsEmpty(DependentCode::kPrototypeCheckGroup));
368 } 368 }
369 } 369 }
370 370
371 371
372 void CodeCache::CodeCacheVerify() {
373 VerifyHeapPointer(default_cache());
374 VerifyHeapPointer(normal_type_cache());
375 CHECK(default_cache()->IsFixedArray());
376 CHECK(normal_type_cache()->IsUndefined()
377 || normal_type_cache()->IsCodeCacheHashTable());
378 }
379
380
381 void PolymorphicCodeCache::PolymorphicCodeCacheVerify() {
382 VerifyHeapPointer(cache());
383 CHECK(cache()->IsUndefined() || cache()->IsPolymorphicCodeCacheHashTable());
384 }
385
386
387 void TypeFeedbackInfo::TypeFeedbackInfoVerify() { 372 void TypeFeedbackInfo::TypeFeedbackInfoVerify() {
388 VerifyObjectField(kStorage1Offset); 373 VerifyObjectField(kStorage1Offset);
389 VerifyObjectField(kStorage2Offset); 374 VerifyObjectField(kStorage2Offset);
390 VerifyObjectField(kStorage3Offset); 375 VerifyObjectField(kStorage3Offset);
391 } 376 }
392 377
393 378
394 void AliasedArgumentsEntry::AliasedArgumentsEntryVerify() { 379 void AliasedArgumentsEntry::AliasedArgumentsEntryVerify() {
395 VerifySmiField(kAliasedContextSlot); 380 VerifySmiField(kAliasedContextSlot);
396 } 381 }
(...skipping 930 matching lines...) Expand 10 before | Expand all | Expand 10 after
1327 1312
1328 // Both are done at the same time. 1313 // Both are done at the same time.
1329 CHECK_EQ(new_it.done(), old_it.done()); 1314 CHECK_EQ(new_it.done(), old_it.done());
1330 } 1315 }
1331 1316
1332 1317
1333 #endif // DEBUG 1318 #endif // DEBUG
1334 1319
1335 } // namespace internal 1320 } // namespace internal
1336 } // namespace v8 1321 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698