Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Side by Side Diff: src/ic/x87/handler-compiler-x87.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/x64/stub-cache-x64.cc ('k') | src/ic/x87/ic-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X87 5 #if V8_TARGET_ARCH_X87
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 741 matching lines...) Expand 10 before | Expand all | Expand 10 after
752 } 752 }
753 __ Push(name); 753 __ Push(name);
754 __ push(value()); 754 __ push(value());
755 __ push(Immediate(Smi::FromInt(language_mode))); 755 __ push(Immediate(Smi::FromInt(language_mode)));
756 __ push(scratch1()); // restore return address 756 __ push(scratch1()); // restore return address
757 757
758 // Do tail-call to the runtime system. 758 // Do tail-call to the runtime system.
759 __ TailCallRuntime(Runtime::kStoreCallbackProperty); 759 __ TailCallRuntime(Runtime::kStoreCallbackProperty);
760 760
761 // Return the generated code. 761 // Return the generated code.
762 return GetCode(kind(), Code::FAST, name); 762 return GetCode(kind(), name);
763 } 763 }
764 764
765 765
766 Register NamedStoreHandlerCompiler::value() { 766 Register NamedStoreHandlerCompiler::value() {
767 return StoreDescriptor::ValueRegister(); 767 return StoreDescriptor::ValueRegister();
768 } 768 }
769 769
770 770
771 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal( 771 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
772 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) { 772 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) {
(...skipping 21 matching lines...) Expand all
794 __ IncrementCounter(counters->ic_named_load_global_stub(), 1); 794 __ IncrementCounter(counters->ic_named_load_global_stub(), 1);
795 // The code above already loads the result into the return register. 795 // The code above already loads the result into the return register.
796 if (IC::ICUseVector(kind())) { 796 if (IC::ICUseVector(kind())) {
797 DiscardVectorAndSlot(); 797 DiscardVectorAndSlot();
798 } 798 }
799 __ ret(0); 799 __ ret(0);
800 800
801 FrontendFooter(name, &miss); 801 FrontendFooter(name, &miss);
802 802
803 // Return the generated code. 803 // Return the generated code.
804 return GetCode(kind(), Code::NORMAL, name); 804 return GetCode(kind(), name);
805 } 805 }
806 806
807 807
808 #undef __ 808 #undef __
809 } // namespace internal 809 } // namespace internal
810 } // namespace v8 810 } // namespace v8
811 811
812 #endif // V8_TARGET_ARCH_X87 812 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/ic/x64/stub-cache-x64.cc ('k') | src/ic/x87/ic-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698