Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: src/ic/x64/handler-compiler-x64.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/stub-cache.cc ('k') | src/ic/x64/ic-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ic/handler-compiler.h" 7 #include "src/ic/handler-compiler.h"
8 8
9 #include "src/api-arguments.h" 9 #include "src/api-arguments.h"
10 #include "src/field-type.h" 10 #include "src/field-type.h"
(...skipping 738 matching lines...) Expand 10 before | Expand all | Expand 10 after
749 } 749 }
750 __ Push(name); 750 __ Push(name);
751 __ Push(value()); 751 __ Push(value());
752 __ Push(Smi::FromInt(language_mode)); 752 __ Push(Smi::FromInt(language_mode));
753 __ PushReturnAddressFrom(scratch1()); 753 __ PushReturnAddressFrom(scratch1());
754 754
755 // Do tail-call to the runtime system. 755 // Do tail-call to the runtime system.
756 __ TailCallRuntime(Runtime::kStoreCallbackProperty); 756 __ TailCallRuntime(Runtime::kStoreCallbackProperty);
757 757
758 // Return the generated code. 758 // Return the generated code.
759 return GetCode(kind(), Code::FAST, name); 759 return GetCode(kind(), name);
760 } 760 }
761 761
762 762
763 Register NamedStoreHandlerCompiler::value() { 763 Register NamedStoreHandlerCompiler::value() {
764 return StoreDescriptor::ValueRegister(); 764 return StoreDescriptor::ValueRegister();
765 } 765 }
766 766
767 767
768 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal( 768 Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(
769 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) { 769 Handle<PropertyCell> cell, Handle<Name> name, bool is_configurable) {
(...skipping 21 matching lines...) Expand all
791 Counters* counters = isolate()->counters(); 791 Counters* counters = isolate()->counters();
792 __ IncrementCounter(counters->ic_named_load_global_stub(), 1); 792 __ IncrementCounter(counters->ic_named_load_global_stub(), 1);
793 if (IC::ICUseVector(kind())) { 793 if (IC::ICUseVector(kind())) {
794 DiscardVectorAndSlot(); 794 DiscardVectorAndSlot();
795 } 795 }
796 __ ret(0); 796 __ ret(0);
797 797
798 FrontendFooter(name, &miss); 798 FrontendFooter(name, &miss);
799 799
800 // Return the generated code. 800 // Return the generated code.
801 return GetCode(kind(), Code::NORMAL, name); 801 return GetCode(kind(), name);
802 } 802 }
803 803
804 804
805 #undef __ 805 #undef __
806 } // namespace internal 806 } // namespace internal
807 } // namespace v8 807 } // namespace v8
808 808
809 #endif // V8_TARGET_ARCH_X64 809 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ic/stub-cache.cc ('k') | src/ic/x64/ic-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698