Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: src/ic/s390/stub-cache-s390.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/s390/ic-s390.cc ('k') | src/ic/stub-cache.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_S390 5 #if V8_TARGET_ARCH_S390
6 6
7 #include "src/ic/stub-cache.h" 7 #include "src/ic/stub-cache.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 #if V8_TARGET_ARCH_S390X 107 #if V8_TARGET_ARCH_S390X
108 // Make sure that code is valid. The multiplying code relies on the 108 // Make sure that code is valid. The multiplying code relies on the
109 // entry size being 24. 109 // entry size being 24.
110 DCHECK(sizeof(Entry) == 24); 110 DCHECK(sizeof(Entry) == 24);
111 #else 111 #else
112 // Make sure that code is valid. The multiplying code relies on the 112 // Make sure that code is valid. The multiplying code relies on the
113 // entry size being 12. 113 // entry size being 12.
114 DCHECK(sizeof(Entry) == 12); 114 DCHECK(sizeof(Entry) == 12);
115 #endif 115 #endif
116 116
117 // Make sure the flags does not name a specific type.
118 DCHECK(Code::ExtractTypeFromFlags(flags) == 0);
119
120 // Make sure that there are no register conflicts. 117 // Make sure that there are no register conflicts.
121 DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3)); 118 DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3));
122 119
123 // Check scratch, extra and extra2 registers are valid. 120 // Check scratch, extra and extra2 registers are valid.
124 DCHECK(!scratch.is(no_reg)); 121 DCHECK(!scratch.is(no_reg));
125 DCHECK(!extra.is(no_reg)); 122 DCHECK(!extra.is(no_reg));
126 DCHECK(!extra2.is(no_reg)); 123 DCHECK(!extra2.is(no_reg));
127 DCHECK(!extra3.is(no_reg)); 124 DCHECK(!extra3.is(no_reg));
128 125
129 #ifdef DEBUG 126 #ifdef DEBUG
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 __ bind(&miss); 175 __ bind(&miss);
179 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 176 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
180 extra3); 177 extra3);
181 } 178 }
182 179
183 #undef __ 180 #undef __
184 } // namespace internal 181 } // namespace internal
185 } // namespace v8 182 } // namespace v8
186 183
187 #endif // V8_TARGET_ARCH_S390 184 #endif // V8_TARGET_ARCH_S390
OLDNEW
« no previous file with comments | « src/ic/s390/ic-s390.cc ('k') | src/ic/stub-cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698