Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: src/ic/ppc/stub-cache-ppc.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ppc/ic-ppc.cc ('k') | src/ic/s390/handler-compiler-s390.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_PPC 5 #if V8_TARGET_ARCH_PPC
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 #if V8_TARGET_ARCH_PPC64 113 #if V8_TARGET_ARCH_PPC64
114 // Make sure that code is valid. The multiplying code relies on the 114 // Make sure that code is valid. The multiplying code relies on the
115 // entry size being 24. 115 // entry size being 24.
116 DCHECK(sizeof(Entry) == 24); 116 DCHECK(sizeof(Entry) == 24);
117 #else 117 #else
118 // Make sure that code is valid. The multiplying code relies on the 118 // Make sure that code is valid. The multiplying code relies on the
119 // entry size being 12. 119 // entry size being 12.
120 DCHECK(sizeof(Entry) == 12); 120 DCHECK(sizeof(Entry) == 12);
121 #endif 121 #endif
122 122
123 // Make sure the flags does not name a specific type.
124 DCHECK(Code::ExtractTypeFromFlags(flags) == 0);
125
126 // Make sure that there are no register conflicts. 123 // Make sure that there are no register conflicts.
127 DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3)); 124 DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3));
128 125
129 // Check scratch, extra and extra2 registers are valid. 126 // Check scratch, extra and extra2 registers are valid.
130 DCHECK(!scratch.is(no_reg)); 127 DCHECK(!scratch.is(no_reg));
131 DCHECK(!extra.is(no_reg)); 128 DCHECK(!extra.is(no_reg));
132 DCHECK(!extra2.is(no_reg)); 129 DCHECK(!extra2.is(no_reg));
133 DCHECK(!extra3.is(no_reg)); 130 DCHECK(!extra3.is(no_reg));
134 131
135 #ifdef DEBUG 132 #ifdef DEBUG
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 182 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
186 extra3); 183 extra3);
187 } 184 }
188 185
189 186
190 #undef __ 187 #undef __
191 } // namespace internal 188 } // namespace internal
192 } // namespace v8 189 } // namespace v8
193 190
194 #endif // V8_TARGET_ARCH_PPC 191 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/ic/ppc/ic-ppc.cc ('k') | src/ic/s390/handler-compiler-s390.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698