Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Side by Side Diff: src/ic/mips64/stub-cache-mips64.cc

Issue 1846963002: Use a dictionary-mode code cache on the map rather than a dual system. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/mips64/ic-mips64.cc ('k') | src/ic/ppc/handler-compiler-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/ic/ic.h" 8 #include "src/ic/ic.h"
9 #include "src/ic/stub-cache.h" 9 #include "src/ic/stub-cache.h"
10 #include "src/interface-descriptors.h" 10 #include "src/interface-descriptors.h"
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 Register name, Register scratch, Register extra, 93 Register name, Register scratch, Register extra,
94 Register extra2, Register extra3) { 94 Register extra2, Register extra3) {
95 Isolate* isolate = masm->isolate(); 95 Isolate* isolate = masm->isolate();
96 Label miss; 96 Label miss;
97 97
98 // Make sure that code is valid. The multiplying code relies on the 98 // Make sure that code is valid. The multiplying code relies on the
99 // entry size being 12. 99 // entry size being 12.
100 // DCHECK(sizeof(Entry) == 12); 100 // DCHECK(sizeof(Entry) == 12);
101 // DCHECK(sizeof(Entry) == 3 * kPointerSize); 101 // DCHECK(sizeof(Entry) == 3 * kPointerSize);
102 102
103 // Make sure the flags does not name a specific type.
104 DCHECK(Code::ExtractTypeFromFlags(flags) == 0);
105
106 // Make sure that there are no register conflicts. 103 // Make sure that there are no register conflicts.
107 DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3)); 104 DCHECK(!AreAliased(receiver, name, scratch, extra, extra2, extra3));
108 105
109 // Check register validity. 106 // Check register validity.
110 DCHECK(!scratch.is(no_reg)); 107 DCHECK(!scratch.is(no_reg));
111 DCHECK(!extra.is(no_reg)); 108 DCHECK(!extra.is(no_reg));
112 DCHECK(!extra2.is(no_reg)); 109 DCHECK(!extra2.is(no_reg));
113 DCHECK(!extra3.is(no_reg)); 110 DCHECK(!extra3.is(no_reg));
114 111
115 #ifdef DEBUG 112 #ifdef DEBUG
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2, 165 __ IncrementCounter(counters->megamorphic_stub_cache_misses(), 1, extra2,
169 extra3); 166 extra3);
170 } 167 }
171 168
172 169
173 #undef __ 170 #undef __
174 } // namespace internal 171 } // namespace internal
175 } // namespace v8 172 } // namespace v8
176 173
177 #endif // V8_TARGET_ARCH_MIPS64 174 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/ic/mips64/ic-mips64.cc ('k') | src/ic/ppc/handler-compiler-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698