third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt - Issue 1846953008: Clip visual rect with real overflow clip rect

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt

Issue 1846953008: Clip visual rect with real overflow clip rect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/spatial-navigation/snav-div-overflow-scrol-hidden.html ('k') | third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/text-color-change-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1	1

2	2

3	3

4	4

5	5

6	6

7	7

8	8

9	9

10 PASS successfullyParsed is true	10 PASS successfullyParsed is true

11	11

12 TEST COMPLETE	12 TEST COMPLETE

13 PASS gFocusedDocument.activeElement.getAttribute("id") is "f2"	13 PASS gFocusedDocument.activeElement.getAttribute("id") is "f2"

14 PASS gFocusedDocument.activeElement.getAttribute("id") is "f3"	14 PASS gFocusedDocument.activeElement.getAttribute("id") is "f3"

15 PASS gFocusedDocument.activeElement.getAttribute("id") is "f3"	15 PASS gFocusedDocument.activeElement.getAttribute("id") is "f3"

16 PASS gFocusedDocument.activeElement.getAttribute("id") is "f4"	16 PASS gFocusedDocument.activeElement.getAttribute("id") is "f4"

17 PASS gFocusedDocument.activeElement.getAttribute("id") is "f4"	17 PASS gFocusedDocument.activeElement.getAttribute("id") is "f4"

18 PASS gFocusedDocument.activeElement.getAttribute("id") is "f5"	18 PASS gFocusedDocument.activeElement.getAttribute("id") is "f5"

	19 PASS gFocusedDocument.activeElement.getAttribute("id") is "f5"
	chrishtr 2016/04/04 16:33:15 Why the changes here? Does this test need to be ad Why the changes here? Does this test need to be adjusted? Xianzhu 2016/04/04 17:46:57 (Sorry, I should have add comment to this file whe Show quoted text On 2016/04/04 16:33:15, chrishtr wrote: > Why the changes here? Does this test need to be adjusted? (Sorry, I should have add comment to this file when I requested for review.) The test tests focus movement in spatial navigation mode when pressing Down key. Focus controller uses absoluteClippedOverflowRect to see if a focus candidate is visible now and will be visible after scrolling. When Down key is pressed when f5 is focused the first time (line 18), without this CL f6 is treated as visible as it has 1 pixel line intersecting the scrolling container's border, and focus is moved to it. Actually f6 is not visible at the time. With this CL, the first Down key (line 18) scrolls the container down making f6 visible, then the next Down key (line 19) focuses f6. This is expected behavior. The new line 20 is of similar situation.
	20 PASS gFocusedDocument.activeElement.getAttribute("id") is "f6"

19 PASS gFocusedDocument.activeElement.getAttribute("id") is "f6"	21 PASS gFocusedDocument.activeElement.getAttribute("id") is "f6"

20 PASS gFocusedDocument.activeElement.getAttribute("id") is "f9"	22 PASS gFocusedDocument.activeElement.getAttribute("id") is "f9"

21 This test is testing that div with overflow:auto would scroll, by div with overf low:hidden would not.	23 This test is testing that div with overflow:auto would scroll, by div with overf low:hidden would not.

OLD	NEW