Allow to reset credential manager first run experience

Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the URL chrome://password-manager-internals/?reset_fre in a
tab.

BUG=599441
Committed: https://crrev.com/cb392e65b5b628539cb970a1268c39c40f425ee1
Cr-Commit-Position: refs/heads/master@{#384273}

[battre, 2016-03-31 12:46:11]

Description was changed from

==========
Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the chrome://password-manager-internals/?reset_fre in a
tab.

BUG=599441
==========

to

==========
Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the chrome://password-manager-internals/?reset_fre in a
tab.

BUG=599441
==========

[battre, 2016-03-31 12:46:11]

battre@chromium.org changed reviewers:
+ vabr@chromium.org, vasilii@chromium.org

[battre, 2016-03-31 12:46:27]

Description was changed from

==========
Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the chrome://password-manager-internals/?reset_fre in a
tab.

BUG=599441
==========

to

==========
Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the URL chrome://password-manager-internals/?reset_fre in
a
tab.

BUG=599441
==========

[battre, 2016-03-31 13:02:26]

Hi.

Could you please review this CL?

Thanks a lot.

Dominic

[vabr (Chromium), 2016-03-31 13:07:48]

LGTM.
I'm explicitly fine with this having no tests, given that it is only meant for
testers and not for external users.

Cheers,
Vaclav

https://codereview.chromium.org/1846943002/diff/1/chrome/browser/ui/webui/pas...
File
chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc
(right):

https://codereview.chromium.org/1846943002/diff/1/chrome/browser/ui/webui/pas...
chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc:84:
// TODO(battre) This may be removed in M53, when the credential manager API
nit: It would be great to have a bug with milestone 53 tracking this and
referenced here as TODO(crbug.com/XXX) instead of the TODO(battre).

[battre, 2016-03-31 13:15:32]

https://codereview.chromium.org/1846943002/diff/1/chrome/browser/ui/webui/pas...
File
chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc
(right):

https://codereview.chromium.org/1846943002/diff/1/chrome/browser/ui/webui/pas...
chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc:84:
// TODO(battre) This may be removed in M53, when the credential manager API
On 2016/03/31 13:07:48, vabr (Chromium) wrote:
> nit: It would be great to have a bug with milestone 53 tracking this and
> referenced here as TODO(crbug.com/XXX) instead of the TODO(battre).

Done.

[vasilii, 2016-03-31 13:21:26]

LGTM if tested manually.

[vabr (Chromium), 2016-03-31 13:23:55]

(Patch set 3 still LGTM.)

[battre, 2016-03-31 13:51:32]

The CQ bit was checked by battre@chromium.org

[commit-bot: I haz the power, 2016-03-31 13:52:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846943002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846943002/40001

[commit-bot: I haz the power, 2016-03-31 14:32:43]

Description was changed from

==========
Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the URL chrome://password-manager-internals/?reset_fre in
a
tab.

BUG=599441
==========

to

==========
Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the URL chrome://password-manager-internals/?reset_fre in
a
tab.

BUG=599441
==========

[commit-bot: I haz the power, 2016-03-31 14:32:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-31 14:34:45]

Description was changed from

==========
Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the URL chrome://password-manager-internals/?reset_fre in
a
tab.

BUG=599441
==========

to

==========
Allow to reset credential manager first run experience

Allow a tester to reset the first run experience state of the credential
manager API by loading the URL chrome://password-manager-internals/?reset_fre in
a
tab.

BUG=599441

Committed: https://crrev.com/cb392e65b5b628539cb970a1268c39c40f425ee1
Cr-Commit-Position: refs/heads/master@{#384273}
==========

[commit-bot: I haz the power, 2016-03-31 14:34:46]

Patchset 3 (id:??) landed as
https://crrev.com/cb392e65b5b628539cb970a1268c39c40f425ee1
Cr-Commit-Position: refs/heads/master@{#384273}