Merge SVGCSSParser into CSSPropertyParser.cpp

Merge SVGCSSParser into CSSPropertyParser.cpp

Because we always compile SVG there is no need anymore to have this in a separate file. Also now we end up with only one isSystemColor.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168179

[pdr., 2014-02-28 22:47:17]

https://codereview.chromium.org/184693003/diff/1/Source/core/css/parser/CSSPr...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/184693003/diff/1/Source/core/css/parser/CSSPr...
Source/core/css/parser/CSSPropertyParser.cpp:56: static bool isSystemColor(int
id)
Can we now remove the version of this from BisonCSSParser-in.cpp?

[rwlbuis, 2014-02-28 23:04:13]

On 2014/02/28 22:47:17, pdr wrote:
>
https://codereview.chromium.org/184693003/diff/1/Source/core/css/parser/CSSPr...
> File Source/core/css/parser/CSSPropertyParser.cpp (right):
> 
>
https://codereview.chromium.org/184693003/diff/1/Source/core/css/parser/CSSPr...
> Source/core/css/parser/CSSPropertyParser.cpp:56: static bool isSystemColor(int
> id)
> Can we now remove the version of this from BisonCSSParser-in.cpp?

Good point. I could move it into CSSPropertyParser where it would remain static?
Not sure if that is the best place....

[rwlbuis, 2014-02-28 23:05:09]

On 2014/02/28 23:04:13, rwlbuis wrote:
> On 2014/02/28 22:47:17, pdr wrote:
> >
>
https://codereview.chromium.org/184693003/diff/1/Source/core/css/parser/CSSPr...
> > File Source/core/css/parser/CSSPropertyParser.cpp (right):
> > 
> >
>
https://codereview.chromium.org/184693003/diff/1/Source/core/css/parser/CSSPr...
> > Source/core/css/parser/CSSPropertyParser.cpp:56: static bool
isSystemColor(int
> > id)
> > Can we now remove the version of this from BisonCSSParser-in.cpp?
> 
> Good point. I could move it into CSSPropertyParser where it would remain
static?
> Not sure if that is the best place....

I meant static on the CSSProperyParser class instead of just local static in the
.cpp.

[eseidel, 2014-02-28 23:21:54]

lgtm

[eseidel, 2014-02-28 23:21:54]

lgtm

lgtm

[commit-bot: I haz the power, 2014-02-28 23:22:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/184693003/1

[eseidel, 2014-02-28 23:22:18]

not lgtm.  pdr is your man.

[eseidel, 2014-02-28 23:22:24]

The CQ bit was unchecked by eseidel@chromium.org

[pdr., 2014-02-28 23:24:19]

On 2014/02/28 23:22:24, eseidel wrote:
> The CQ bit was unchecked by mailto:eseidel@chromium.org

LGTM

[pdr., 2014-02-28 23:24:23]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-02-28 23:24:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/184693003/20001

[eseidel, 2014-02-28 23:26:39]

Maybe we can convince you to do https://codereview.chromium.org/171233004/ too .
:)

[rwlbuis, 2014-02-28 23:52:49]

On 2014/02/28 23:26:39, eseidel wrote:
> Maybe we can convince you to do https://codereview.chromium.org/171233004/ too
.
> :)

I'll have a look.

[commit-bot: I haz the power, 2014-03-01 00:46:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-01 00:46:20]

Retried try job too often on blink_android_compile_rel for step(s) webkit_lint
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...

[pdr., 2014-03-01 00:52:03]

On 2014/03/01 00:46:20, I haz the power (commit-bot) wrote:
> Retried try job too often on blink_android_compile_rel for step(s) webkit_lint
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...

Sadly, I think this is a real failure.

[rwlbuis, 2014-03-01 01:14:04]

On 2014/03/01 00:52:03, pdr wrote:
> On 2014/03/01 00:46:20, I haz the power (commit-bot) wrote:
> > Retried try job too often on blink_android_compile_rel for step(s)
webkit_lint
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_andr...
> 
> Sadly, I think this is a real failure.

Seems to work ok now, I guess it was just a glitch.

[rwlbuis, 2014-03-01 01:16:50]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-03-01 01:17:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/184693003/20001

[commit-bot: I haz the power, 2014-03-01 01:50:15]

Change committed as 168179

[jbroman, 2014-03-01 01:57:05]

On 2014/03/01 01:50:15, I haz the power (commit-bot) wrote:
> Change committed as 168179

Why doesn't this change also delete SVGCSSParser.cpp?

[rwlbuis, 2014-03-03 00:38:23]

On 2014/03/01 01:57:05, jbroman wrote:
> On 2014/03/01 01:50:15, I haz the power (commit-bot) wrote:
> > Change committed as 168179
> 
> Why doesn't this change also delete SVGCSSParser.cpp?

Oops, you are right! I'll do it tomorrow unless somebody beats be to it.