third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp - Issue 1846913009: HeapSupplements are now just Supplements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp

Issue 1846913009: HeapSupplements are now just Supplements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h ('k') | third_party/WebKit/Source/modules/quota/DOMWindowQuota.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp b/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp

index 4e884d38a89899109554202894d836d3e511bb73..8164a2f0315128b1eaf33cf3151891cb2881ed1c 100644

--- a/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp

@@ -25,7 +25,7 @@ const char* ServiceWorkerRegistrationPush::supplementName()

ServiceWorkerRegistrationPush& ServiceWorkerRegistrationPush::from(ServiceWorkerRegistration& registration)

{

- ServiceWorkerRegistrationPush* supplement = static_cast<ServiceWorkerRegistrationPush*>(HeapSupplement<ServiceWorkerRegistration>::from(registration, supplementName()));

+ ServiceWorkerRegistrationPush* supplement = static_cast<ServiceWorkerRegistrationPush*>(Supplement<ServiceWorkerRegistration>::from(registration, supplementName()));

if (!supplement) {

supplement = new ServiceWorkerRegistrationPush(&registration);

provideTo(registration, supplementName(), supplement);

@@ -49,7 +49,7 @@ DEFINE_TRACE(ServiceWorkerRegistrationPush)

{

visitor->trace(m_registration);

visitor->trace(m_pushManager);

- HeapSupplement<ServiceWorkerRegistration>::trace(visitor);

+ Supplement<ServiceWorkerRegistration>::trace(visitor);

}

} // namespace blink