third_party/WebKit/Source/modules/geolocation/GeolocationController.h - Issue 1846913009: HeapSupplements are now just Supplements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/GeolocationController.h

Issue 1846913009: HeapSupplements are now just Supplements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/geofencing/WorkerNavigatorGeofencing.cpp ('k') | third_party/WebKit/Source/modules/geolocation/GeolocationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/GeolocationController.h

diff --git a/third_party/WebKit/Source/modules/geolocation/GeolocationController.h b/third_party/WebKit/Source/modules/geolocation/GeolocationController.h

index dac3c16a6b3e8b80c757d1b3191028f40f48620f..e2e7a92a01d0afd96ba38c9363e19ca9392dc18f 100644

--- a/third_party/WebKit/Source/modules/geolocation/GeolocationController.h

+++ b/third_party/WebKit/Source/modules/geolocation/GeolocationController.h

@@ -40,7 +40,7 @@ class GeolocationClient;

class GeolocationError;

class GeolocationPosition;

-class MODULES_EXPORT GeolocationController : public GarbageCollectedFinalized<GeolocationController>, public HeapSupplement<LocalFrame>, public PageLifecycleObserver {

+class MODULES_EXPORT GeolocationController : public GarbageCollectedFinalized<GeolocationController>, public Supplement<LocalFrame>, public PageLifecycleObserver {

USING_GARBAGE_COLLECTED_MIXIN(GeolocationController);

WTF_MAKE_NONCOPYABLE(GeolocationController);

public:

@@ -67,7 +67,7 @@ public:

void pageVisibilityChanged() override;

static const char* supplementName();

- static GeolocationController* from(LocalFrame* frame) { return static_cast<GeolocationController*>(HeapSupplement<LocalFrame>::from(frame, supplementName())); }

+ static GeolocationController* from(LocalFrame* frame) { return static_cast<GeolocationController*>(Supplement<LocalFrame>::from(frame, supplementName())); }

// Inherited from Supplement.

DECLARE_VIRTUAL_TRACE();