third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp - Issue 1846913009: HeapSupplements are now just Supplements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp

Issue 1846913009: HeapSupplements are now just Supplements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp

diff --git a/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp b/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp

index a75ae8ae11e17df10578e2539e2cb450f18e2d99..adcbe4762ce9900d8e8955303c4f2542ac284642 100644

--- a/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp

+++ b/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp

@@ -32,7 +32,7 @@ NavigatorBeacon::~NavigatorBeacon()

DEFINE_TRACE(NavigatorBeacon)

{

LocalFrameLifecycleObserver::trace(visitor);

- HeapSupplement<Navigator>::trace(visitor);

+ Supplement<Navigator>::trace(visitor);

}

const char* NavigatorBeacon::supplementName()

@@ -42,7 +42,7 @@ const char* NavigatorBeacon::supplementName()

NavigatorBeacon& NavigatorBeacon::from(Navigator& navigator)

{

- NavigatorBeacon* supplement = static_cast<NavigatorBeacon*>(HeapSupplement<Navigator>::from(navigator, supplementName()));

+ NavigatorBeacon* supplement = static_cast<NavigatorBeacon*>(Supplement<Navigator>::from(navigator, supplementName()));

if (!supplement) {

supplement = new NavigatorBeacon(navigator);

provideTo(navigator, supplementName(), supplement);