Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 1846913007: Mac: Disable use of AVSampleBufferDisplayLayer (Closed)

Created:
4 years, 8 months ago by ccameron
Modified:
4 years, 8 months ago
Reviewers:
erikchen
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Disable use of AVSampleBufferDisplayLayer This is part of the constellation of patches that together caused crashes and corruption. Take this out of the equation. BUG=594449 Committed: https://crrev.com/4144e9eb946d938bdef4b88166a3708ca62e2b28 Cr-Commit-Position: refs/heads/master@{#384799}

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 1

Patch Set 3 : https #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M content/common/gpu/ca_layer_tree_mac.mm View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/gpu/ca_layer_tree_unittest_mac.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ccameron
Sadness += 1.
4 years, 8 months ago (2016-04-01 20:06:17 UTC) #2
erikchen
lgtm https://codereview.chromium.org/1846913007/diff/20001/content/common/gpu/ca_layer_tree_mac.mm File content/common/gpu/ca_layer_tree_mac.mm (right): https://codereview.chromium.org/1846913007/diff/20001/content/common/gpu/ca_layer_tree_mac.mm#newcode260 content/common/gpu/ca_layer_tree_mac.mm:260: // http://crbug.com/598243, http://crbug.com/598388 s/http/https
4 years, 8 months ago (2016-04-01 20:16:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846913007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846913007/40001
4 years, 8 months ago (2016-04-01 21:19:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/44273)
4 years, 8 months ago (2016-04-01 22:38:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846913007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846913007/40001
4 years, 8 months ago (2016-04-02 08:09:14 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-02 08:13:50 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 08:15:17 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4144e9eb946d938bdef4b88166a3708ca62e2b28
Cr-Commit-Position: refs/heads/master@{#384799}

Powered by Google App Engine
This is Rietveld 408576698