Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1846903003:
Add virtual suite: fast/images --force-gpu-rasterization (Closed)
|
Created:
4 years, 8 months ago by Noel Gordon Modified:
4 years, 8 months ago Reviewers:
alancutter (OOO until 2018) CC:
chromium-reviews, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd virtual suite: fast/images --force-gpu-rasterization
One test (pixel crack) is a timeout. The remaining changes are because
the images in the test are being rescaled and the rescaling is done on
the GPU with this flag, but in Skia software without the flag, causing
minor differences in the test results: rebaseline them.
BUG=600087
Committed: https://crrev.com/8a842c7971b4c2ffc5d375592bd37b933ba215b6
Cr-Commit-Position: refs/heads/master@{#384845}
Patch Set 1 #Patch Set 2 : Add TestExpectations #Patch Set 3 : Add pixel-crack-image-background-webkit-transform-scale.html #Patch Set 4 : Add pixel-crack-image-background-webkit-transform-scale.html Timeout #
Total comments: 2
Messages
Total messages: 44 (26 generated)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Add virtual suite: fast/images --force-gpu-rasterization BUG= ========== to ========== Add virtual suite: fast/images --force-gpu-rasterization BUG=600087 ==========
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903003/20001
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903003/40001
Patchset #2 (id:20001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Patchset #4 (id:80001) has been deleted
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Patchset #4 (id:100001) has been deleted
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903003/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
alancutter@chromium.org changed reviewers: + alancutter@chromium.org
lgtm with nit. https://codereview.chromium.org/1846903003/diff/120001/third_party/WebKit/Lay... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1846903003/diff/120001/third_party/WebKit/Lay... third_party/WebKit/LayoutTests/TestExpectations:985: We should mention in the description why these tests need rebaselining.
Description was changed from ========== Add virtual suite: fast/images --force-gpu-rasterization BUG=600087 ========== to ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with the flag, rather than in Skia software without the flag, causing a minor difference in the test result images. BUG=600087 ==========
noel@chromium.org changed reviewers: - alancutter@chromium.org
Description was changed from ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with the flag, rather than in Skia software without the flag, causing a minor difference in the test result images. BUG=600087 ========== to ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled, and that rescaling is done on the GPU with the flag and in Skia software without the flag, causing the minor difference in the test result images. BUG=600087 ==========
Description was changed from ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled, and that rescaling is done on the GPU with the flag and in Skia software without the flag, causing the minor difference in the test result images. BUG=600087 ========== to ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with this flag, but in Skia software without the flag, causing minor differences in the test result images: rebaseline them. BUG=600087 ==========
Description was changed from ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with this flag, but in Skia software without the flag, causing minor differences in the test result images: rebaseline them. BUG=600087 ========== to ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with this flag, but in Skia software without the flag, causing minor differences in the test results: rebaseline them. BUG=600087 ==========
https://codereview.chromium.org/1846903003/diff/120001/third_party/WebKit/Lay... File third_party/WebKit/LayoutTests/TestExpectations (right): https://codereview.chromium.org/1846903003/diff/120001/third_party/WebKit/Lay... third_party/WebKit/LayoutTests/TestExpectations:985: On 2016/04/04 01:56:05, alancutter wrote: > We should mention in the description why these tests need rebaselining. The reason for the rebselines was described in the CL change description, if that is what you meant.
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846903003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846903003/120001
Message was sent while issue was closed.
Description was changed from ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with this flag, but in Skia software without the flag, causing minor differences in the test results: rebaseline them. BUG=600087 ========== to ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with this flag, but in Skia software without the flag, causing minor differences in the test results: rebaseline them. BUG=600087 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with this flag, but in Skia software without the flag, causing minor differences in the test results: rebaseline them. BUG=600087 ========== to ========== Add virtual suite: fast/images --force-gpu-rasterization One test (pixel crack) is a timeout. The remaining changes are because the images in the test are being rescaled and the rescaling is done on the GPU with this flag, but in Skia software without the flag, causing minor differences in the test results: rebaseline them. BUG=600087 Committed: https://crrev.com/8a842c7971b4c2ffc5d375592bd37b933ba215b6 Cr-Commit-Position: refs/heads/master@{#384845} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/8a842c7971b4c2ffc5d375592bd37b933ba215b6 Cr-Commit-Position: refs/heads/master@{#384845} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
