Interface with webrtc through encoded frames

remoting/protocol/webrtc_frame_scheduler.h

Index: remoting/protocol/webrtc_frame_scheduler.h
diff --git a/remoting/protocol/webrtc_frame_scheduler.h b/remoting/protocol/webrtc_frame_scheduler.h
new file mode 100644
index 0000000000000000000000000000000000000000..77b8a4f26e48ce2b9cdf5f3e5b74da265352b8b5
--- /dev/null
+++ b/remoting/protocol/webrtc_frame_scheduler.h
@@ -0,0 +1,96 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_PROTOCOL_WEBRTC_FRAME_SCHEDULER_H_
+#define REMOTING_PROTOCOL_WEBRTC_FRAME_SCHEDULER_H_
+
+#include "base/macros.h"
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/memory/weak_ptr.h"
+#include "base/single_thread_task_runner.h"
+#include "base/task/cancelable_task_tracker.h"
+#include "base/threading/thread_checker.h"
+#include "base/timer/timer.h"
+#include "remoting/codec/video_encoder.h"
+#include "remoting/protocol/webrtc_transport.h"
+#include "third_party/webrtc/modules/desktop_capture/desktop_capturer.h"
+#include "third_party/webrtc/modules/desktop_capture/desktop_frame.h"
+
+namespace remoting {
+namespace protocol {
+
+// Class responsible for scheduling frames for encode and hand-over to
+// WebRtc transport for sending across the network.
+class WebRtcFrameScheduler : public webrtc::DesktopCapturer::Callback {

[Sergey Ulanov, 2016/03/31 22:06:19]

nit: In other places we use Webrtc prefix with lower-case r.

[Irfan, 2016/04/05 21:23:27]

I feel like this is something remoting should fix in other places since
third_party/webrtc/ uses WebRTC... for class names.

In the mean time, if you insist, I could use Webrtc for consistency

+ public:
+  typedef base::Callback<void(const webrtc::DesktopSize& size)> SizeCallback;
+
+  WebRtcFrameScheduler(
+      scoped_refptr<base::SingleThreadTaskRunner> encode_task_runner,
+      scoped_ptr<webrtc::DesktopCapturer> capturer,
+      WebrtcTransport* webrtc_transport,
+      scoped_ptr<VideoEncoder> encoder);
+  ~WebRtcFrameScheduler() override;
+
+  // Starts scheduling frames to be encoded and transported.
+  void Start();
+  // Stops scheduling frames.
+  void Stop();
+
+  void SetSizeCallback(const SizeCallback& size_callback);
+
+ private:
+  // webrtc::DesktopCapturer::Callback interface.
+  webrtc::SharedMemory* CreateSharedMemory(size_t size) override;
+  void OnCaptureCompleted(webrtc::DesktopFrame* frame) override;
+
+  // Callback for CaptureScheduler.
+  void CaptureNextFrame();
+
+  // Task running on the encoder thread to encode the |frame|.
+  void EncodeFrame(scoped_ptr<webrtc::DesktopFrame> frame);
+  void OnFrameEncoded();
+
+  void SetKeyFrameRequest();
+  bool ClearAndGetKeyFrameRequest();
+
+  // Protects |key_frame_request_|.
+  mutable base::Lock lock_;
+  bool key_frame_request_;
+
+  bool capture_pending_;
+  bool encode_pending_;
+
+  webrtc::DesktopSize frame_size_;
+  SizeCallback size_callback_;
+
+  // Task runner used to run |encoder_|.
+  scoped_refptr<base::SingleThreadTaskRunner> encode_task_runner_;
+  base::CancelableTaskTracker task_tracker_;
+  base::CancelableTaskTracker::TaskId task_id_;

[Sergey Ulanov, 2016/03/31 22:06:19]

task_id_ is not used anywhere.

[Irfan, 2016/04/05 21:23:27]

Done.

+
+  // Capturer used to capture the screen.
+  scoped_ptr<webrtc::DesktopCapturer> capturer_;
+
+  scoped_ptr<base::RepeatingTimer> capture_timer_;
+
+  // Used to send across encoded frames.
+  WebrtcTransport* webrtc_transport_;
+
+  // Used to encode captured frames. Always accessed on the encode thread.
+  scoped_ptr<VideoEncoder> encoder_;
+
+  base::ThreadChecker thread_checker_;
+  base::TimeTicks last_capture_ticks_;
+
+  base::WeakPtrFactory<WebRtcFrameScheduler> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(WebRtcFrameScheduler);
+};
+
+}  // namespace protocol
+}  // namespace remoting
+
+#endif  // REMOTING_PROTOCOL_WEBRTC_FRAME_SCHEDULER_H_