Interface with webrtc through encoded frames

remoting/codec/video_encoder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_CODEC_VIDEO_ENCODER_H_
 #define REMOTING_CODEC_VIDEO_ENCODER_H_
 
+#include <stdint.h>
+
 #include "base/memory/scoped_ptr.h"
 
 namespace webrtc {
 class DesktopFrame;
 }  // namespace webrtc
 
 namespace remoting {
 
 class VideoPacket;
 
 // A class to perform the task of encoding a continuous stream of images. The
 // interface is asynchronous to enable maximum throughput.
 class VideoEncoder {
  public:
+  enum Flags { kRequestKeyFrame = 1 << 0 };

[Sergey Ulanov, 2016/04/07 21:05:39]

Call it REQUEST_KEY_FRAME. See
https://www.chromium.org/developers/coding-style#TOC-Naming

[Irfan, 2016/04/12 21:13:11]

Done.

   virtual ~VideoEncoder() {}
 
   // Request that the encoder provide lossless encoding, or color, if possible.
   virtual void SetLosslessEncode(bool want_lossless) {}
   virtual void SetLosslessColor(bool want_lossless) {}
 
   // Encode an image stored in |frame|. If |frame.updated_region()| is empty
   // then the encoder may return a packet (e.g. to top-off previously-encoded
   // portions of the frame to higher quality) or return nullptr to indicate that
   // there is no work to do.
-  virtual scoped_ptr<VideoPacket> Encode(const webrtc::DesktopFrame& frame) = 0;
+  virtual scoped_ptr<VideoPacket> Encode(const webrtc::DesktopFrame& frame,
+                                         uint32_t flags = 0) = 0;

[Sergey Ulanov, 2016/04/07 21:05:39]

style guide doesn't allow optional arguments.

You can overload this function to avoid changing all callers:
scoped_ptr<VideoPacket> Encode(const webrtc::DesktopFrame& frame) {
  return Encode(frame, 0);
}

But there shouldn't be many call sites, so it should be possible to update all
of thme.

[Irfan, 2016/04/12 21:13:11]

Done.

 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_CODEC_VIDEO_ENCODER_H_