Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1846873002:
Allow spaces in GN target names on Windows. (Closed)
|
Created:
4 years, 8 months ago by brettw Modified:
4 years, 8 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow spaces in GN target names on Windows.
This allows executables with spaces in their names to work on Windows. Posix probably needs a separate patch.
BUG=599326
Committed: https://crrev.com/7508242a626ddf83422d3224f6bc14f553b88a3f
Cr-Commit-Position: refs/heads/master@{#384445}
Patch Set 1 #Patch Set 2 : #
Total comments: 2
Patch Set 3 : #
Total comments: 1
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Allow spaces in GN target names on Windows. This allows executables with spaces in their names to work on Windows. Posix probably needs a separate patch. ========== to ========== Allow spaces in GN target names on Windows. This allows executables with spaces in their names to work on Windows. Posix probably needs a separate patch. BUG=599326 ==========
brettw@chromium.org changed reviewers: + dpranke@google.com
brettw@chromium.org changed reviewers: + dpranke@chromium.org - dpranke@google.com
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846873002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1846873002/diff/20001/build/toolchain/win/BUI... File build/toolchain/win/BUILD.gn (right): https://codereview.chromium.org/1846873002/diff/20001/build/toolchain/win/BUI... build/toolchain/win/BUILD.gn:77: command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd\"$pdbname\"" Don't you have this issue all over the place if target or label_name contains spaces? i.e., I would think that {{output}} and $rspfile might need to be quoted, too.
The CQ bit was checked by brettw@chromium.org to run a CQ dry run
https://codereview.chromium.org/1846873002/diff/20001/build/toolchain/win/BUI... File build/toolchain/win/BUILD.gn (right): https://codereview.chromium.org/1846873002/diff/20001/build/toolchain/win/BUI... build/toolchain/win/BUILD.gn:77: command = "ninja -t msvc -e $env -- $cl /nologo /showIncludes /FC @$rspfile /c {{source}} /Fo{{output}} /Fd\"$pdbname\"" I added a comment explaining the reason for this.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846873002/40001
lgtm https://codereview.chromium.org/1846873002/diff/40001/build/toolchain/win/BUI... File build/toolchain/win/BUILD.gn (right): https://codereview.chromium.org/1846873002/diff/40001/build/toolchain/win/BUI... build/toolchain/win/BUILD.gn:80: # full file name and will quote automatically when necessary. Ah. thank you.
The CQ bit was unchecked by brettw@chromium.org
The CQ bit was checked by brettw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846873002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846873002/40001
Message was sent while issue was closed.
Description was changed from ========== Allow spaces in GN target names on Windows. This allows executables with spaces in their names to work on Windows. Posix probably needs a separate patch. BUG=599326 ========== to ========== Allow spaces in GN target names on Windows. This allows executables with spaces in their names to work on Windows. Posix probably needs a separate patch. BUG=599326 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Allow spaces in GN target names on Windows. This allows executables with spaces in their names to work on Windows. Posix probably needs a separate patch. BUG=599326 ========== to ========== Allow spaces in GN target names on Windows. This allows executables with spaces in their names to work on Windows. Posix probably needs a separate patch. BUG=599326 Committed: https://crrev.com/7508242a626ddf83422d3224f6bc14f553b88a3f Cr-Commit-Position: refs/heads/master@{#384445} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/7508242a626ddf83422d3224f6bc14f553b88a3f Cr-Commit-Position: refs/heads/master@{#384445} |
