third_party/WebKit/Source/modules/mediasource/MediaSource.cpp - Issue 1846863002: Remove SourceBuffer media tracks on detach from media element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasource/MediaSource.cpp

Issue 1846863002: Remove SourceBuffer media tracks on detach from media element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-sb-tracks6

Patch Set: CR feedback Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-avtracks.html ('K') | « third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-avtracks.html ('k') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasource/MediaSource.cpp

diff --git a/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp b/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp

index 8089d192192a7819bef165474418bb66f7797609..096ab7ddecc5b80e18d328d8959e91bc1a29a03f 100644

--- a/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp

+++ b/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp

@@ -215,6 +215,8 @@ void MediaSource::onReadyStateChange(const AtomicString& oldState, const AtomicS

m_sourceBuffers->item(i)->removedFromMediaSource();

m_sourceBuffers->clear();

+ m_attachedElement.clear();

scheduleEvent(EventTypeNames::sourceclose);

}

@@ -450,7 +452,6 @@ void MediaSource::setReadyState(const AtomicString& state)

if (state == closedKeyword()) {

m_webMediaSource.clear();

- m_attachedElement.clear();

}

if (oldState == state)