third_party/WebKit/Source/modules/mediasource/SourceBuffer.h - Issue 1846863002: Remove SourceBuffer media tracks on detach from media element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

Issue 1846863002: Remove SourceBuffer media tracks on detach from media element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink-sb-tracks6

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-avtracks.html ('K') | « third_party/WebKit/LayoutTests/http/tests/media/media-source/mediasource-avtracks.html ('k') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp » ('j') | third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

diff --git a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

index baa22e3470961b191e2b530b339d1866e181cec3..c4150638461e2d3518f9a919f3373dacd022429a 100644

--- a/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

+++ b/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h

@@ -136,6 +136,8 @@ private:

void appendStreamDone(bool success);

void clearAppendStreamState();

+ void removeMediaTracks();

// FileReaderLoaderClient interface

void didStartLoading() override;

void didReceiveDataForClient(const char* data, unsigned dataLength) override;