Issue 1846803002: Fix webgl methods, properly this time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1846803002: Fix webgl methods, properly this time (Closed)

Created:
4 years, 8 months ago by Alan Knight

Modified:
4 years, 8 months ago

Reviewers:
terry

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -21 lines)			Patch
M	sdk/lib/web_gl/dart2js/web_gl_dart2js.dart	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	sdk/lib/web_gl/dartium/web_gl_dartium.dart	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	tests/compiler/dart2js/analyze_api_test.dart	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_WebGLRenderingContext.darttemplate	View		2 chunks	+4 lines, -6 lines	0 comments	Download

Total messages: 6 (2 generated)

kevmoo

On 2016/03/31 00:06:19, Alan Knight wrote: > TBR TB-committed?

4 years, 8 months ago (2016-03-31 16:18:14 UTC) #3

Alan Knight

Committed patchset #2 (id:20001) manually as 0f5c249f22b7dc7dd1f6d052b36e386b7534a8b9 (presubmit successful).

4 years, 8 months ago (2016-03-31 16:45:41 UTC) #5

Alan Knight

4 years, 8 months ago (2016-03-31 16:52:56 UTC) #6

Message was sent while issue was closed.

I try not to land things if it's too late in the day to have a full bot cycle
and fix/rollback before I leave.