Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1846773002: Make SkRandom::next[US]Fixed1 private; update documentation for SkRandom::nextSScalar1. (Closed)

Created:
4 years, 8 months ago by dogben
Modified:
4 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkRandom::next[US]Fixed1 private; update documentation for SkRandom::nextSScalar1. SkRandom is unused in Chromium, Android, Mozilla, and Google3. SkRandom::nextSScalar1 and LCGRandom::nextSScalar1 appear to me by inspection to potentially return -1, so I updated the documentation to match. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1846773002 Committed: https://skia.googlesource.com/skia/+/1263448196dec4a5b601dabeb56b5fb24c1d72fa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M bench/GrMemoryPoolBench.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M include/utils/SkRandom.h View 3 chunks +11 lines, -11 lines 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846773002/1
4 years, 8 months ago (2016-03-30 23:12:24 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-03-30 23:23:17 UTC) #5
dogben
4 years, 8 months ago (2016-03-31 00:41:08 UTC) #8
reed1
lgtm
4 years, 8 months ago (2016-03-31 10:59:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846773002/1
4 years, 8 months ago (2016-03-31 13:12:26 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 13:13:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1263448196dec4a5b601dabeb56b5fb24c1d72fa

Powered by Google App Engine
This is Rietveld 408576698