Fix wrong box-shadow visual overflow with flipped blocks writing mode

Fix wrong box-shadow visual overflow with flipped blocks writing mode

BUG=599573
TEST=fast/box-shadow/shadow-box-resize-writing-mode.html
TEST=LayoutObjectTest.OverflowRectMappingWithSelfFlippedWritingMode
TEST=LayoutObjectTest.OverflowRectMappingWithContainerFlippedWritingMode

Committed: https://crrev.com/ac7511d8075f109d87040a2d782b641d4b8e40c9
Cr-Commit-Position: refs/heads/master@{#384613}

[Xianzhu, 2016-03-31 20:26:04]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, wkorman@chromium.org

[wkorman, 2016-03-31 21:05:29]

lgtm

[chrishtr, 2016-04-01 00:42:09]

https://codereview.chromium.org/1846753004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp (right):

https://codereview.chromium.org/1846753004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp:221:
EXPECT_EQ(LayoutRect(222, 111, 140, 70), rect);
Why is it offset by 222, 111? Isn't that the size of the view?

[Xianzhu, 2016-04-01 01:17:23]

https://codereview.chromium.org/1846753004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp (right):

https://codereview.chromium.org/1846753004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp:221:
EXPECT_EQ(LayoutRect(222, 111, 140, 70), rect);
On 2016/04/01 00:42:09, chrishtr wrote:
> Why is it offset by 222, 111? Isn't that the size of the view?

They are absolute position of 'target' ("position absolute; top: 111px; left:
222px"). Using special numbers to make it obvious in the result and avoid
accidental correct result when the algorithm were wrong.

[Xianzhu, 2016-04-01 04:42:48]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 04:43:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846753004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846753004/1

[commit-bot: I haz the power, 2016-04-01 04:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 04:50:08]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2016-04-01 16:50:58]

lgtm

https://codereview.chromium.org/1846753004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp (right):

https://codereview.chromium.org/1846753004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp:221:
EXPECT_EQ(LayoutRect(222, 111, 140, 70), rect);
On 2016/04/01 at 01:17:22, Xianzhu wrote:
> On 2016/04/01 00:42:09, chrishtr wrote:
> > Why is it offset by 222, 111? Isn't that the size of the view?
> 
> They are absolute position of 'target' ("position absolute; top: 111px; left:
222px"). Using special numbers to make it obvious in the result and avoid
accidental correct result when the algorithm were wrong.

Oh right sorry.

[Xianzhu, 2016-04-01 16:52:02]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-04-01 16:52:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846753004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846753004/1

[commit-bot: I haz the power, 2016-04-01 17:00:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-01 17:03:23]

Description was changed from

==========
Fix wrong box-shadow visual overflow with flipped blocks writing mode

BUG=599573
TEST=fast/box-shadow/shadow-box-resize-writing-mode.html
TEST=LayoutObjectTest.OverflowRectMappingWithSelfFlippedWritingMode
TEST=LayoutObjectTest.OverflowRectMappingWithContainerFlippedWritingMode
==========

to

==========
Fix wrong box-shadow visual overflow with flipped blocks writing mode

BUG=599573
TEST=fast/box-shadow/shadow-box-resize-writing-mode.html
TEST=LayoutObjectTest.OverflowRectMappingWithSelfFlippedWritingMode
TEST=LayoutObjectTest.OverflowRectMappingWithContainerFlippedWritingMode

Committed: https://crrev.com/ac7511d8075f109d87040a2d782b641d4b8e40c9
Cr-Commit-Position: refs/heads/master@{#384613}
==========

[commit-bot: I haz the power, 2016-04-01 17:03:24]

Patchset 1 (id:??) landed as
https://crrev.com/ac7511d8075f109d87040a2d782b641d4b8e40c9
Cr-Commit-Position: refs/heads/master@{#384613}