Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 184673002: Make RenderObject non-copyable. (Closed)

Created:
6 years, 9 months ago by ostap
Modified:
6 years, 9 months ago
Reviewers:
Inactive
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make RenderObject non-copyable. Important since pointers been replaced with references. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/core/rendering/RenderObject.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ostap
6 years, 9 months ago (2014-02-28 15:57:04 UTC) #1
Inactive
lgtm Yes, now that we use more references, this is important.
6 years, 9 months ago (2014-02-28 16:08:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/184673002/1
6 years, 9 months ago (2014-02-28 16:08:41 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 19:20:11 UTC) #4
Message was sent while issue was closed.
Change committed as 168157

Powered by Google App Engine
This is Rietveld 408576698