Gracefully handle unloaded scripts

Gracefully handle unloaded scripts

If a script is unloaded between the collection of an allocation and the
tranlation of an allocation profile, the profiler will segfault. With
this change, we report unloaded scripts as having no line number,column
number, or name.

R=ofrobots@google.com
BUG=

Committed: https://crrev.com/607143d4603a2d211b87952b939de738a07b60d7
Cr-Commit-Position: refs/heads/master@{#35147}

[ofrobots, 2016-03-30 22:35:35]

https://codereview.chromium.org/1846723002/diff/1/src/profiler/sampling-heap-...
File src/profiler/sampling-heap-profiler.cc (right):

https://codereview.chromium.org/1846723002/diff/1/src/profiler/sampling-heap-...
src/profiler/sampling-heap-profiler.cc:204: scripts.count(node->script_id_)) {
Why use map::count? map::find would be more intuitive.

https://codereview.chromium.org/1846723002/diff/1/test/cctest/test-heap-profi...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/1846723002/diff/1/test/cctest/test-heap-profi...
test/cctest/test-heap-profiler.cc:2897: const char* gced =
Use a more descriptive name or, better, inline the script source below at the
only use of this variable.

[mattloring, 2016-03-30 23:55:09]

https://codereview.chromium.org/1846723002/diff/1/src/profiler/sampling-heap-...
File src/profiler/sampling-heap-profiler.cc (right):

https://codereview.chromium.org/1846723002/diff/1/src/profiler/sampling-heap-...
src/profiler/sampling-heap-profiler.cc:204: scripts.count(node->script_id_)) {
On 2016/03/30 22:35:35, ofrobots wrote:
> Why use map::count? map::find would be more intuitive.

Done.

https://codereview.chromium.org/1846723002/diff/1/test/cctest/test-heap-profi...
File test/cctest/test-heap-profiler.cc (right):

https://codereview.chromium.org/1846723002/diff/1/test/cctest/test-heap-profi...
test/cctest/test-heap-profiler.cc:2897: const char* gced =
On 2016/03/30 22:35:35, ofrobots wrote:
> Use a more descriptive name or, better, inline the script source below at the
> only use of this variable.

Done.

[ofrobots, 2016-03-30 23:56:34]

Description was changed from

==========
Gracefully handle unloaded scripts

If a script is unloaded between the collection of an allocation and the
tranlation of an allocation profile, the profiler will segfault. With
this change, we report unloaded scripts as having no line number,column
number, or name.

R=ofrobots@google.com
BUG=
==========

to

==========
Gracefully handle unloaded scripts

If a script is unloaded between the collection of an allocation and the
tranlation of an allocation profile, the profiler will segfault. With
this change, we report unloaded scripts as having no line number,column
number, or name.

R=ofrobots@google.com
BUG=
==========

[ofrobots, 2016-03-30 23:56:34]

ofrobots@google.com changed reviewers:
+ alph@chromium.org, yangguo@chromium.org

[ofrobots, 2016-03-30 23:56:45]

On 2016/03/30 23:56:34, ofrobots wrote:
> mailto:ofrobots@google.com changed reviewers:
> + mailto:alph@chromium.org, mailto:yangguo@chromium.org

lgtm from me.

[Yang, 2016-03-31 05:12:56]

lgtm.

[mattloring, 2016-03-31 06:04:00]

The CQ bit was checked by mattloring@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 06:04:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846723002/20001

[commit-bot: I haz the power, 2016-03-31 06:31:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 06:31:55]

Dry run: This issue passed the CQ dry run.

[mattloring, 2016-03-31 06:33:47]

The CQ bit was checked by mattloring@google.com

[commit-bot: I haz the power, 2016-03-31 06:33:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1846723002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1846723002/20001

[commit-bot: I haz the power, 2016-03-31 06:36:11]

Description was changed from

==========
Gracefully handle unloaded scripts

If a script is unloaded between the collection of an allocation and the
tranlation of an allocation profile, the profiler will segfault. With
this change, we report unloaded scripts as having no line number,column
number, or name.

R=ofrobots@google.com
BUG=
==========

to

==========
Gracefully handle unloaded scripts

If a script is unloaded between the collection of an allocation and the
tranlation of an allocation profile, the profiler will segfault. With
this change, we report unloaded scripts as having no line number,column
number, or name.

R=ofrobots@google.com
BUG=
==========

[commit-bot: I haz the power, 2016-03-31 06:36:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-31 06:36:41]

Description was changed from

==========
Gracefully handle unloaded scripts

If a script is unloaded between the collection of an allocation and the
tranlation of an allocation profile, the profiler will segfault. With
this change, we report unloaded scripts as having no line number,column
number, or name.

R=ofrobots@google.com
BUG=
==========

to

==========
Gracefully handle unloaded scripts

If a script is unloaded between the collection of an allocation and the
tranlation of an allocation profile, the profiler will segfault. With
this change, we report unloaded scripts as having no line number,column
number, or name.

R=ofrobots@google.com
BUG=

Committed: https://crrev.com/607143d4603a2d211b87952b939de738a07b60d7
Cr-Commit-Position: refs/heads/master@{#35147}
==========

[commit-bot: I haz the power, 2016-03-31 06:36:43]

Patchset 2 (id:??) landed as
https://crrev.com/607143d4603a2d211b87952b939de738a07b60d7
Cr-Commit-Position: refs/heads/master@{#35147}

[ofrobots, 2016-03-31 17:09:44]

On 2016/03/31 06:36:43, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/607143d4603a2d211b87952b939de738a07b60d7
> Cr-Commit-Position: refs/heads/master@{#35147}

It seems that this issue was fixed twice concurrently. alph@ also fixed this
issue recently here: https://codereview.chromium.org/1826953003/

One of these changes should be rolled back, but the test case from this issue
should be preserved.