third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h - Issue 1846713004: Remove premultipliedAlpha from WebGraphicsContext3D::Attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Issue 1846713004: Remove premultipliedAlpha from WebGraphicsContext3D::Attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: premul: tests2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp ('k') | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

diff --git a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

index d2b172cdbe612bb43510ca148ce4ab246ce11a4e..140c949d5d472fff8e6c7f4f20360ebe22e8ff02 100644

--- a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

+++ b/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

@@ -76,7 +76,7 @@ public:

Discard

};

- static PassRefPtr<DrawingBuffer> create(PassOwnPtr<WebGraphicsContext3DProvider>, const IntSize&, PreserveDrawingBuffer, WebGraphicsContext3D::Attributes requestedAttributes);

+ static PassRefPtr<DrawingBuffer> create(PassOwnPtr<WebGraphicsContext3DProvider>, const IntSize&, bool premultipliedAlpha, PreserveDrawingBuffer, WebGraphicsContext3D::Attributes requestedAttributes);

static void forceNextDrawingBufferCreationToFail();

~DrawingBuffer() override;

@@ -185,6 +185,7 @@ protected: // For unittests

PassOwnPtr<Extensions3DUtil>,

bool multisampleExtensionSupported,

bool discardFramebufferSupported,

+ bool premultipliedAlpha,

PreserveDrawingBuffer,

WebGraphicsContext3D::Attributes requestedAttributes);

@@ -313,6 +314,7 @@ private:

WebGraphicsContext3D::Attributes m_requestedAttributes;

bool m_multisampleExtensionSupported;

bool m_discardFramebufferSupported;

+ bool m_premultipliedAlpha;

GLuint m_fbo;

// DrawingBuffer's output is double-buffered. m_colorBuffer is the back buffer.

TextureInfo m_colorBuffer;