Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1846713004: Remove premultipliedAlpha from WebGraphicsContext3D::Attributes. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
CC:
chrishtr, bajones, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dcheng, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, Ken Russell (switch to Gerrit), kinuko+watch, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, piman, rwlbuis, Stephen Chennney, no sievers, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove premultipliedAlpha from WebGraphicsContext3D::Attributes. This field is read from WebGLContextAttributes, and used in DrawingBuffer, but is not part of creating a GL context. So just pass it to DrawingBuffer and store it as a bool on that class. R=chrishtr@chromium.org, kbr@chromium.org BUG=584497 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/4f2c3eaf0c747d75d0e930ace6f27483f0394c8d Cr-Commit-Position: refs/heads/master@{#384369}

Patch Set 1 #

Patch Set 2 : premul: tests #

Patch Set 3 : premul: tests2 #

Messages

Total messages: 32 (16 generated)
danakj
4 years, 8 months ago (2016-03-31 01:16:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846713004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846713004/1
4 years, 8 months ago (2016-03-31 01:16:27 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oilpan_rel/builds/23860)
4 years, 8 months ago (2016-03-31 01:31:21 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846713004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846713004/40001
4 years, 8 months ago (2016-03-31 01:35:05 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/204373)
4 years, 8 months ago (2016-03-31 02:19:56 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846713004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846713004/40001
4 years, 8 months ago (2016-03-31 02:23:52 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/146886)
4 years, 8 months ago (2016-03-31 02:33:25 UTC) #14
Ken Russell (switch to Gerrit)
lgtm
4 years, 8 months ago (2016-03-31 02:35:08 UTC) #15
danakj
TBR=chrishtr
4 years, 8 months ago (2016-03-31 02:41:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846713004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846713004/40001
4 years, 8 months ago (2016-03-31 02:41:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846713004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846713004/40001
4 years, 8 months ago (2016-03-31 02:42:08 UTC) #22
chrishtr
lgtm
4 years, 8 months ago (2016-03-31 04:24:08 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/196727)
4 years, 8 months ago (2016-03-31 07:49:48 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846713004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846713004/40001
4 years, 8 months ago (2016-03-31 18:58:52 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-31 20:17:06 UTC) #30
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 20:19:36 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f2c3eaf0c747d75d0e930ace6f27483f0394c8d
Cr-Commit-Position: refs/heads/master@{#384369}

Powered by Google App Engine
This is Rietveld 408576698