Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1846713003: Add call tree filter to Observatory CPU profile tree (Closed)

Created:
4 years, 8 months ago by Cutch
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add call tree filter to Observatory CPU profile tree BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/b1eb8859a5e814d766cf9b73b15b9314b9fc35df

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -45 lines) Patch
M runtime/observatory/lib/src/cpu_profile/cpu_profile.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.dart View 1 2 4 chunks +54 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/cpu_profile.html View 1 2 3 1 chunk +48 lines, -39 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Cutch
4 years, 8 months ago (2016-03-31 15:57:47 UTC) #1
Cutch
4 years, 8 months ago (2016-03-31 15:57:59 UTC) #4
rmacnak
I get an error switching the tree direction. https://chromiumcodereview.appspot.com/1846713003/diff/20001/runtime/observatory/lib/src/elements/cpu_profile.html File runtime/observatory/lib/src/elements/cpu_profile.html (right): https://chromiumcodereview.appspot.com/1846713003/diff/20001/runtime/observatory/lib/src/elements/cpu_profile.html#newcode163 runtime/observatory/lib/src/elements/cpu_profile.html:163: <div ...
4 years, 8 months ago (2016-03-31 17:03:32 UTC) #5
Cutch
https://chromiumcodereview.appspot.com/1846713003/diff/20001/runtime/observatory/lib/src/elements/cpu_profile.html File runtime/observatory/lib/src/elements/cpu_profile.html (right): https://chromiumcodereview.appspot.com/1846713003/diff/20001/runtime/observatory/lib/src/elements/cpu_profile.html#newcode163 runtime/observatory/lib/src/elements/cpu_profile.html:163: <div class="memberName">Call Tree Filter</div> On 2016/03/31 17:03:32, rmacnak wrote: ...
4 years, 8 months ago (2016-03-31 18:08:49 UTC) #6
rmacnak
lgtm
4 years, 8 months ago (2016-03-31 19:25:50 UTC) #7
Cutch
4 years, 8 months ago (2016-04-01 13:41:16 UTC) #9
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b1eb8859a5e814d766cf9b73b15b9314b9fc35df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698