Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1050)

Unified Diff: base/build_time_unittest.cc

Issue 1846713002: Improve the error message in BuildTime.InThePast to help figure out the problem. (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: With fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/build_time_unittest.cc
diff --git a/base/build_time_unittest.cc b/base/build_time_unittest.cc
index 30d541aed1c8db7b293e8e8f3546b69a3d376f6d..e21aed9fadb8aa712c68b4de4e26324c483e6d9f 100644
--- a/base/build_time_unittest.cc
+++ b/base/build_time_unittest.cc
@@ -16,15 +16,7 @@ TEST(BuildTime, DateLooksValid) {
EXPECT_EQ(' ', build_date[6]);
}
-TEST(BuildTime, TimeLooksValid) {
Nico 2016/03/30 20:34:00 what's wrong with this test? …oh. Yes, this is no
- char build_time[] = "00:00:00";
-
- EXPECT_EQ(8u, strlen(build_time));
- EXPECT_EQ(':', build_time[2]);
- EXPECT_EQ(':', build_time[5]);
-}
-
TEST(BuildTime, InThePast) {
- EXPECT_TRUE(base::GetBuildTime() < base::Time::Now());
- EXPECT_TRUE(base::GetBuildTime() < base::Time::NowFromSystemTime());
+ EXPECT_LT(base::GetBuildTime(), base::Time::Now());
+ EXPECT_LT(base::GetBuildTime(), base::Time::NowFromSystemTime());
}

Powered by Google App Engine
This is Rietveld 408576698