Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1846683006: [stubs] Introduce ToIntegerStub and unify the handling of %_ToInteger. (Closed)

Created:
4 years, 8 months ago by Benedikt Meurer
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Introduce ToIntegerStub and unify the handling of %_ToInteger. This adds a new TurboFan-based ToIntegerStub, similar to the ToLengthStub, and uses it whereever we had custom code for %_ToInteger previously. R=yangguo@chromium.org BUG=v8:4587 LOG=n Committed: https://crrev.com/6761224c9775878555c46798e919198a6bc75039 Cr-Commit-Position: refs/heads/master@{#35190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -202 lines) Patch
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +1 line, -34 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +7 lines, -16 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 8 months ago (2016-04-01 07:35:08 UTC) #1
Benedikt Meurer
Hey Yang, Some cleanup now that we have Float64Trunc in the CodeStubAssembler. :-) Please take ...
4 years, 8 months ago (2016-04-01 07:35:39 UTC) #2
Yang
lgtm
4 years, 8 months ago (2016-04-01 07:44:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846683006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846683006/1
4 years, 8 months ago (2016-04-01 07:44:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 08:00:43 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 08:02:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6761224c9775878555c46798e919198a6bc75039
Cr-Commit-Position: refs/heads/master@{#35190}

Powered by Google App Engine
This is Rietveld 408576698