Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: media/base/mime_util_internal.cc

Issue 1846683003: Merge M50: "Spitzer: Report Opus in Ogg as supported by unified pipeline" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2661
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mime_util_internal.cc
diff --git a/media/base/mime_util_internal.cc b/media/base/mime_util_internal.cc
index a0ce3c4951698d5f3f101f1d0cb4f866b4ca7ac3..07e908e7cfd67ce7278e99f053c913675ae84f2e 100644
--- a/media/base/mime_util_internal.cc
+++ b/media/base/mime_util_internal.cc
@@ -84,16 +84,14 @@ static const MediaFormat kFormatCodecMappings[] = {
{"audio/webm", COMMON, "opus,vorbis"},
{"audio/wav", COMMON, "1"},
{"audio/x-wav", COMMON, "1"},
-#if defined(OS_ANDROID)
- // Android does not support Opus in Ogg container.
- // Android does not support Theora and thus video/ogg.
- {"audio/ogg", COMMON, "vorbis"},
- {"application/ogg", COMMON, "vorbis"},
-#else
+#if !defined(OS_ANDROID)
+ // Note: Android does not support Theora and thus video/ogg.
{"video/ogg", COMMON, "opus,theora,vorbis"},
+#endif
{"audio/ogg", COMMON, "opus,vorbis"},
+ // Note: Theora is not supported on Android and will be rejected during the
+ // call to IsCodecSupportedOnPlatform().
{"application/ogg", COMMON, "opus,theora,vorbis"},
-#endif
#if defined(USE_PROPRIETARY_CODECS)
{"audio/mpeg", PROPRIETARY, "mp3"},
{"audio/mp3", PROPRIETARY, ""},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698