Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1846673002: [Media Router] Conditionally enable mDNS on Windows. (Closed)

Created:
4 years, 8 months ago by Wez
Modified:
4 years, 8 months ago
Reviewers:
apacible, amp
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Media Router] Conditionally enable mDNS on Windows. This change enables mDNS on Windows only when the user is in a context related to the Media Router. Previously, a firewall prompt could be triggered on browser startup which is confusing. BUG=593167 R=apacible@chromium.org,amp@chromium.org Review URL: https://codereview.chromium.org/1821823002 Cr-Commit-Position: refs/heads/master@{#383689} (cherry picked from commit 74d51922f5dc2516ce51cb49a36c0b4180ada30e) Committed: https://chromium.googlesource.com/chromium/src/+/a0651df3f75e0f21ab919d845a048029601ad230

Patch Set 1 #

Patch Set 2 : Patch-up newly-added test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -8 lines) Patch
M chrome/browser/media/android/router/media_router_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/android/router/media_router_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_route_provider_util_win.h View 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/media/router/media_route_provider_util_win.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router.mojom View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_metrics.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.h View 4 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl.cc View 6 chunks +56 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_impl_unittest.cc View 1 5 chunks +73 lines, -0 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_test.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/media/router/media_router_mojo_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/media/router/mock_media_router.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media/router/test_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_ui.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M extensions/renderer/resources/media_router_bindings.js View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
Wez
4 years, 8 months ago (2016-03-30 19:12:09 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a0651df3f75e0f21ab919d845a048029601ad230.

Powered by Google App Engine
This is Rietveld 408576698